Backport to 4.14 and 4.19 commits 24c363623361 and 17ecffa28948 and a798a7086c38

Backport to 4.14 and 4.19 commits 24c363623361 and 17ecffa28948 and a798a7086c38

[Christophe Leroy]

Hi,

Could you please backport the three following commits to 4.14 and 4.19:

24c363623361 ("spi: spi-fsl-spi: remove always-true conditional in 
fsl_spi_do_one_msg")
17ecffa28948 ("spi: spi-fsl-spi: relax message sanity checking a little")
a798a7086c38 ("spi: spi-fsl-spi: allow changing bits_per_word while CS 
is still active")

Those three commits (the last one indeed) are needed to overcome a 
problem introduced in 4.14.230 by commit 42c04316d927 ("spi: fsl-cpm: 
Use 16 bit mode for large transfers with even size"), which leads to the 
following error in certain cases:

[  174.900526] at25 spi0.3: bits_per_word/speed_hz should be same for 
the same SPI transfer
[  174.911844] spi_master spi0: failed to transfer one message from queue
[  366.639467] INFO: task od:406 blocked for more than 120 seconds.
[  366.645155]       Not tainted 4.14.320-s3k-dev-dirty #342
[  366.652996] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" 
disables this message.
[  489.519450] INFO: task od:406 blocked for more than 120 seconds.
[  489.525156]       Not tainted 4.14.320-s3k-dev-dirty #342
[  489.532915] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" 
disables this message.
...

Thanks
Christophe

Re: Backport to 4.14 and 4.19 commits 24c363623361 and 17ecffa28948 and a798a7086c38

[Greg Kroah-Hartman]

On Thu, Jul 13, 2023 at 03:34:10PM +0000, Christophe Leroy wrote:
> Hi,
> 
> Could you please backport the three following commits to 4.14 and 4.19:
> 
> 24c363623361 ("spi: spi-fsl-spi: remove always-true conditional in 
> fsl_spi_do_one_msg")
> 17ecffa28948 ("spi: spi-fsl-spi: relax message sanity checking a little")
> a798a7086c38 ("spi: spi-fsl-spi: allow changing bits_per_word while CS 
> is still active")
> 
> Those three commits (the last one indeed) are needed to overcome a 
> problem introduced in 4.14.230 by commit 42c04316d927 ("spi: fsl-cpm: 
> Use 16 bit mode for large transfers with even size"), which leads to the 
> following error in certain cases:
> 
> [  174.900526] at25 spi0.3: bits_per_word/speed_hz should be same for 
> the same SPI transfer
> [  174.911844] spi_master spi0: failed to transfer one message from queue
> [  366.639467] INFO: task od:406 blocked for more than 120 seconds.
> [  366.645155]       Not tainted 4.14.320-s3k-dev-dirty #342
> [  366.652996] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" 
> disables this message.
> [  489.519450] INFO: task od:406 blocked for more than 120 seconds.
> [  489.525156]       Not tainted 4.14.320-s3k-dev-dirty #342
> [  489.532915] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" 
> disables this message.
> ...

Now queued up, thanks.

greg k-h