[PATCH] spi: spi-cadence-quadspi: Fix missing unwind goto warnings

[PATCH] spi: spi-cadence-quadspi: Fix missing unwind goto warnings

[Dhruva Gole]

Fix the smatch warnings that were recently introduced in the runtime pm
patch [0]:
drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
unwind goto?

[0] https://lore.kernel.org/all/20230829062706.786637-1-d-gole@ti.com/

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202309140543.03dMbMM5-lkp@intel.com/
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---

Link: https://lore.kernel.org/r/20230915123103.2493640-1-d-gole@ti.com

Tested locally using the following cmd:
make -j32 ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- drivers/spi/spi-cadence-quadspi.o CHECK="smatch -p=kernel" C=1 W=1

 drivers/spi/spi-cadence-quadspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 4828da4587c5..e04f257c1067 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1879,7 +1879,7 @@ static int cqspi_probe(struct platform_device *pdev)
 
 	ret = devm_pm_runtime_enable(dev);
 	if (ret)
-		return ret;
+		goto probe_setup_failed;
 
 	pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
 	pm_runtime_use_autosuspend(dev);
-- 
2.34.1

Re: [PATCH] spi: spi-cadence-quadspi: Fix missing unwind goto warnings

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

On Fri, Sep 15, 2023 at 06:01:04PM +0530, Dhruva Gole wrote:
> Fix the smatch warnings that were recently introduced in the runtime pm
> patch [0]:
> drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
> unwind goto?
> 
> [0] https://lore.kernel.org/all/20230829062706.786637-1-d-gole@ti.com/

Please use normal fixes tags for things like this and in general
please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on trains or flights, or while
otherwise travelling so this is even more pressing for me than just
being about making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: spi-cadence-quadspi: Fix missing unwind goto warnings

[Dhruva Gole]

On Sep 15, 2023 at 13:49:23 +0100, Mark Brown wrote:
> On Fri, Sep 15, 2023 at 06:01:04PM +0530, Dhruva Gole wrote:
> > Fix the smatch warnings that were recently introduced in the runtime pm
> > patch [0]:
> > drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
> > unwind goto?
> > 
> > [0] https://lore.kernel.org/all/20230829062706.786637-1-d-gole@ti.com/
> 
> Please use normal fixes tags for things like this and in general

OK, I will resend with fixes tag.

> please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on trains or flights, or while
> otherwise travelling so this is even more pressing for me than just
> being about making things a bit easier to read.

Will keep this in mind!

Also, I think a better fix will do, as I just noticed I am not really
doing a dma_release_channel in this path although I got rid of the
warning.


-- 
Best regards,
Dhruva Gole <d-gole@ti.com>