* Re: [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in dspi_request_dma()
[not found] <20230719071239.4736-1-duminjie@vivo.com>
@ 2023-07-19 12:42 ` Mark Brown
[not found] ` <SG2PR06MB5288FB4E5CB1FD5E0FB6D18BAE3FA@SG2PR06MB5288.apcprd06.prod.outlook.com>
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2023-07-19 12:42 UTC (permalink / raw)
To: 杜敏杰
Cc: Vladimir Oltean, Richard Cochran,
open list:FREESCALE DSPI DRIVER, open list,
open list:PTP HARDWARE CLOCK SUPPORT, opensource.kernel
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
On Wed, Jul 19, 2023 at 07:13:02AM +0000, 杜敏杰 wrote:
> - dev_err(dev, "rx dma channel not available\n");
> - ret = PTR_ERR(dma->chan_rx);
> - return ret;
> + return dev_err_probe(dev, PTR_ERR(dma->chan_rx),
> + "rx dma channel not available\n");
The indentation on the second line is messed up here, it's far too
indented.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 回复: [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in dspi_request_dma()
[not found] ` <SG2PR06MB5288FB4E5CB1FD5E0FB6D18BAE3FA@SG2PR06MB5288.apcprd06.prod.outlook.com>
@ 2023-07-21 10:55 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-07-21 10:55 UTC (permalink / raw)
To: 杜敏杰
Cc: Vladimir Oltean, Richard Cochran,
open list:FREESCALE DSPI DRIVER, open list,
open list:PTP HARDWARE CLOCK SUPPORT, opensource.kernel
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
On Fri, Jul 21, 2023 at 02:54:26AM +0000, 杜敏杰 wrote:
> You said:
> > The indentation on the second line is messed up here, it's far too indented.
> Could you tell me what is the specification for indentation?
Documentation/process/coding-style.rst and more generally things should
look like the nearby code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-21 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230719071239.4736-1-duminjie@vivo.com>
2023-07-19 12:42 ` [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in dspi_request_dma() Mark Brown
[not found] ` <SG2PR06MB5288FB4E5CB1FD5E0FB6D18BAE3FA@SG2PR06MB5288.apcprd06.prod.outlook.com>
2023-07-21 10:55 ` 回复: " Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).