From: Ryan Mallon <ryan-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
To: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org,
broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org,
alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org
Subject: Re: [PATCH v5 08/12] gpio: add ti-ssp gpio driver
Date: Tue, 16 Nov 2010 11:38:09 +1300 [thread overview]
Message-ID: <4CE1B651.1060006@bluewatersys.com> (raw)
In-Reply-To: <1289848334-8695-9-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
On 11/16/2010 08:12 AM, Cyril Chemparathy wrote:
> TI's SSP controller pins can be directly read and written to behave like a
> GPIO. This patch adds a GPIO driver that exposes such functionality.
>
> Signed-off-by: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>
> ---
> drivers/mfd/Kconfig | 10 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/ti-ssp-gpio.c | 205 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/ti_ssp.h | 4 +
> 4 files changed, 220 insertions(+), 0 deletions(-)
> create mode 100644 drivers/mfd/ti-ssp-gpio.c
Should go under drivers/gpio. This is not a multifunction driver.
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/io.h>
> +#include <linux/err.h>
> +#include <linux/slab.h>
> +#include <linux/gpio.h>
> +#include <linux/platform_device.h>
> +#include <linux/mfd/ti_ssp.h>
> +
> +struct ti_ssp_gpio {
This is a confusing name because it sounds like this struct maps to a
single gpio rather than bank. Perhaps a better name is ti_ssp_gpio_chip?
> + struct gpio_chip chip;
> +#define chip2gpio(chip) container_of(chip, struct ti_ssp_gpio, chip)
Please don't put #define's in the middle of a struct. Move it either
before or after the structure definition. It is also confusingly named,
something like to_ti_ssp_gpio_chip might be better.
> +static int value_get(struct gpio_chip *chip, unsigned gpio_num)
> +{
> + struct ti_ssp_gpio *gpio = chip2gpio(chip);
> + int ret;
> +
> + spin_lock(&gpio->lock);
> +
> + ret = ti_ssp_raw_read(gpio->dev);
> + if (ret >= 0)
> + ret = (ret & BIT(gpio_num)) ? 1 : 0;
ret = !!(ret & BIT(gpio_num));
> +
> + spin_unlock(&gpio->lock);
> + return ret;
> +}
> +static int __devinit ti_ssp_gpio_probe(struct platform_device *pdev)
> +{
> + const struct ti_ssp_gpio_data *pdata = pdev->dev.platform_data;
> + struct device *dev = &pdev->dev;
> + struct ti_ssp_gpio *gpio;
> + int error;
> +
> + if (!pdata) {
> + dev_err(dev, "platform data not found\n");
> + return -EINVAL;
> + }
> +
> + gpio = kzalloc(sizeof(*gpio), GFP_KERNEL);
> + if (!gpio) {
> + dev_err(dev, "cannot allocate driver data\n");
> + return -ENOMEM;
> + }
> +
> + gpio->dev = dev;
> + gpio->iosel = SSP_PIN_SEL(0, SSP_IN) | SSP_PIN_SEL(1, SSP_IN) |
> + SSP_PIN_SEL(2, SSP_IN) | SSP_PIN_SEL(3, SSP_IN);
> + error = ti_ssp_set_iosel(gpio->dev, gpio->iosel);
> + if (error < 0) {
> + dev_err(dev, "gpio io setup failed (%d)\n", error);
> + goto error;
> + }
> +
> + spin_lock_init(&gpio->lock);
> + platform_set_drvdata(pdev, gpio);
> +
> + gpio->chip.base = pdata->start;
> + gpio->chip.ngpio = 4;
Is this always four or can the SSP peripheral be configured to have
varying numbers of gpios. Maybe the number of gpios should be passed via
platform data?
> + gpio->chip.dev = &pdev->dev;
> + gpio->chip.label = "ti_ssp_gpio";
> + gpio->chip.owner = THIS_MODULE;
> + gpio->chip.get = value_get;
> + gpio->chip.set = value_set;
> + gpio->chip.direction_input = direction_in;
> + gpio->chip.direction_output = direction_out;
> +
> + error = gpiochip_add(&gpio->chip);
> + if (error < 0) {
> + dev_err(dev, "gpio chip registration failed (%d)\n", error);
> + goto error;
> + }
> +
> + dev_info(dev, "ssp gpio interface registered\n");
> + return 0;
> +
> +error:
> + kfree(gpio);
> + return error;
> +}
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
next prev parent reply other threads:[~2010-11-15 22:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 19:12 [PATCH v5 00/12] tnetv107x ssp drivers Cyril Chemparathy
[not found] ` <1289848334-8695-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-15 19:12 ` [PATCH v5 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
[not found] ` <1289848334-8695-2-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-16 7:10 ` Grant Likely
[not found] ` <20101116071047.GE4074-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-11-16 16:15 ` Cyril Chemparathy
[not found] ` <4CE2AE3C.4040805-l0cyMroinI0@public.gmane.org>
2010-11-16 20:35 ` Grant Likely
[not found] ` <AANLkTik76EY8Xh01YP2Tep6k1ETPO+3idmNuk3pVikJG-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-16 21:19 ` Cyril Chemparathy
2010-11-16 22:23 ` Russell King - ARM Linux
[not found] ` <20101116222340.GF21926-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2010-11-16 23:57 ` Grant Likely
2010-11-15 19:12 ` [PATCH v5 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
2010-11-15 21:59 ` Ryan Mallon
[not found] ` <1289848334-8695-5-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-16 7:22 ` Grant Likely
[not found] ` <20101116072225.GF4074-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-11-16 7:47 ` Grant Likely
2010-11-16 11:34 ` Mark Brown
[not found] ` <20101116113409.GH3338-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2010-11-16 20:45 ` Grant Likely
[not found] ` <20101116204554.GB5016-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-11-16 22:48 ` Mark Brown
[not found] ` <AANLkTi=utWumLKo9QVWXpkC8WxpgaNJJs+dj=pa2eq-q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-17 0:17 ` Cyril Chemparathy
2010-11-17 13:31 ` Mark Brown
[not found] ` <20101117133136.GA19488-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-11-17 15:25 ` David Brownell
[not found] ` <781931.83221.qm-g47maUHHHF+ORdMXk8NaZPu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
2010-11-17 17:54 ` Cyril Chemparathy
[not found] ` <4CE31F0E.7050103-l0cyMroinI0@public.gmane.org>
2010-11-17 16:11 ` Grant Likely
[not found] ` <20101117161130.GC5757-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-11-17 17:23 ` Mark Brown
2010-11-17 17:35 ` Cyril Chemparathy
2010-11-18 5:46 ` Greg KH
2010-11-25 23:32 ` Rafael J. Wysocki
2010-11-16 14:19 ` David Brownell
2010-11-15 19:12 ` [PATCH v5 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 08/12] gpio: add ti-ssp gpio driver Cyril Chemparathy
[not found] ` <1289848334-8695-9-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-11-15 22:38 ` Ryan Mallon [this message]
[not found] ` <4CE1B651.1060006-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2010-11-16 19:38 ` Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
2010-11-15 19:12 ` [PATCH v5 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE1B651.1060006@bluewatersys.com \
--to=ryan-7wk5f4od5/oyd5yxfr4s2w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=cyril-l0cyMroinI0@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).