linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "tiantao (H)" <tiantao6@huawei.com>
To: Mark Brown <broonie@kernel.org>, Tian Tao <tiantao6@hisilicon.com>
Cc: <linux-spi@vger.kernel.org>
Subject: Re: [PATCH] spi: davinci: Use of_device_get_match_data() helper
Date: Tue, 30 Mar 2021 08:53:00 +0800	[thread overview]
Message-ID: <67027863-b52d-ad32-6e17-af5c1d284216@huawei.com> (raw)
In-Reply-To: <20210329152157.GB5166@sirena.org.uk>


在 2021/3/29 23:21, Mark Brown 写道:
> On Mon, Mar 29, 2021 at 04:58:36PM +0800, Tian Tao wrote:
>
>> +	spi_data = (struct davinci_spi_of_data *)
>> +			of_device_get_match_data(&pdev->dev);
>> +	if (!spi_data)
> If we need to cast away from void * that's most likely pointing at a
> bug.

Even with of_match_device, there is still a type conversion，as follows

spi_data = (struct davinci_spi_of_data *)match->data;

Using of_device_get_match_data instead of of_match_device doesn't look 
like a problem from the code, other spi drivers do the same thing



  reply	other threads:[~2021-03-30  0:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29  8:58 [PATCH] spi: davinci: Use of_device_get_match_data() helper Tian Tao
2021-03-29 15:21 ` Mark Brown
2021-03-30  0:53   ` tiantao (H) [this message]
2021-03-30 10:47     ` Mark Brown
2021-03-30 11:56     ` Fabio Estevam
2021-03-30 12:11       ` tiantao (H)
2021-03-30 12:15         ` Fabio Estevam
2021-03-30 12:17           ` tiantao (H)
2021-03-30 12:12       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67027863-b52d-ad32-6e17-af5c1d284216@huawei.com \
    --to=tiantao6@huawei.com \
    --cc=broonie@kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=tiantao6@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).