From: Fabio Estevam <festevam@gmail.com>
To: "tiantao (H)" <tiantao6@huawei.com>
Cc: Mark Brown <broonie@kernel.org>,
Tian Tao <tiantao6@hisilicon.com>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH] spi: davinci: Use of_device_get_match_data() helper
Date: Tue, 30 Mar 2021 09:15:33 -0300 [thread overview]
Message-ID: <CAOMZO5Ad5L-y9YTiOantOWow_CPaeGnNMjf8hM_-eH4ShMQS7A@mail.gmail.com> (raw)
In-Reply-To: <bc792674-dca3-8fd7-dc55-3fceb1de4524@huawei.com>
On Tue, Mar 30, 2021 at 9:12 AM tiantao (H) <tiantao6@huawei.com> wrote:
> From what I have tested, the results are ok. I will send v2 to fix.
>
> make modules M=drivers/spi/
> CC [M] drivers/spi//spi-davinci.o
> drivers/spi//spi-davinci.c: In function ‘spi_davinci_get_pdata’:
> drivers/spi//spi-davinci.c:826:11: warning: assignment discards ‘const’
> qualifier from pointer target type [-Wdiscarded-qualifiers]
> 826 | spi_data = of_device_get_match_data(&pdev->dev);
This warning does not appear if you apply the patch I suggested.
next prev parent reply other threads:[~2021-03-30 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 8:58 [PATCH] spi: davinci: Use of_device_get_match_data() helper Tian Tao
2021-03-29 15:21 ` Mark Brown
2021-03-30 0:53 ` tiantao (H)
2021-03-30 10:47 ` Mark Brown
2021-03-30 11:56 ` Fabio Estevam
2021-03-30 12:11 ` tiantao (H)
2021-03-30 12:15 ` Fabio Estevam [this message]
2021-03-30 12:17 ` tiantao (H)
2021-03-30 12:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5Ad5L-y9YTiOantOWow_CPaeGnNMjf8hM_-eH4ShMQS7A@mail.gmail.com \
--to=festevam@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=tiantao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).