[PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platform

[PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platform

[Feng Tang]

Hi David,

This patch series adds driver for SPI controller of Intel Moorestown platform.

This driver has been tested with Maxim's Max3110 UART device and
Option's 3G modem GTM501L, both PIO and DMA works fine, and these
2 slave devcies can work simultaneously

User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet

please help to review them.

I haven't seen your mail on this list for a while, so I cc' Andrew and Alan
for their reviews as well.

Thanks,
Feng


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects

Re: [PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platform

[Baruch Siach]

Hi Feng,

On Mon, Jun 15, 2009 at 05:38:45PM +0800, Feng Tang wrote:
> This patch series adds driver for SPI controller of Intel Moorestown 
> platform.
> 
> This driver has been tested with Maxim's Max3110 UART device and
> Option's 3G modem GTM501L, both PIO and DMA works fine, and these
> 2 slave devcies can work simultaneously
> 
> User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet

Wow. This is a big surprise for me. I was working on a driver of the Synopsys 
Designware SPI controller myself during the last year. I posted my work on 
this list and got reviews from Linus Walleij. No word from David Brownell yet.  
I'll look into your work and see whether we can merge the drivers.

My first comment is regarding the name of the driver. This should be 
designware_spi, as this IP block appears in other chips as well, and is not 
Intel Moorestown specific.

> please help to review them.
> 
> I haven't seen your mail on this list for a while, so I cc' Andrew and Alan
> for their reviews as well.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects

Re: [PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platform

[Tang, Feng]

>-----Original Message-----
>From: Baruch Siach [mailto:baruch@tkos.co.il]
>Sent: 2009年6月15日 18:18
>To: Tang, Feng
>Cc: dbrownell@users.sourceforge.net; spi-devel-general@lists.sourceforge.net;
>akpm@linux-foundation.org; alan@lxorguk.ukuu.org.uk
>Subject: Re: [spi-devel-general] [PATCH 0/2] spi: add driver for SPI controller of Intel
>Moorestown platform
>
>Hi Feng,
>
>On Mon, Jun 15, 2009 at 05:38:45PM +0800, Feng Tang wrote:
>> This patch series adds driver for SPI controller of Intel Moorestown
>> platform.
>>
>> This driver has been tested with Maxim's Max3110 UART device and
>> Option's 3G modem GTM501L, both PIO and DMA works fine, and these
>> 2 slave devcies can work simultaneously
>>
>> User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
>
>Wow. This is a big surprise for me. I was working on a driver of the Synopsys
>Designware SPI controller myself during the last year. I posted my work on
>this list and got reviews from Linus Walleij. No word from David Brownell yet.
>I'll look into your work and see whether we can merge the drivers.

Good idea, we can work together to make the driver better.

Regarding the driver name, it is implemented as a PCI device driver, also it has
some Moorestown specific stuff like DMA operation, DMA part of the driver only
works with the DMA controller on Moorestown, that's why I used such a name.
Anyway, we can discuss more about it.

Thanks,
Feng
>
>My first comment is regarding the name of the driver. This should be
>designware_spi, as this IP block appears in other chips as well, and is not
>Intel Moorestown specific.
>
>> please help to review them.
>>
>> I haven't seen your mail on this list for a while, so I cc' Andrew and Alan
>> for their reviews as well.
>
>baruch
>
>--
>                                                     ~. .~   Tk Open
>Systems
>=}------------------------------------------------ooO--U--Ooo------------{=
>   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platform

[David Brownell]

On Monday 15 June 2009, Tang, Feng wrote:
> >>
> >> User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
> >
> >Wow. This is a big surprise for me. I was working on a driver of the Synopsys
> >Designware SPI controller myself during the last year. I posted my work on
> >this list and got reviews from Linus Walleij. No word from David Brownell yet.
> >I'll look into your work and see whether we can merge the drivers.
> 
> Good idea, we can work together to make the driver better.
> 
> Regarding the driver name, it is implemented as a PCI device driver, also it has
> some Moorestown specific stuff like DMA operation, DMA part of the driver only
> works with the DMA controller on Moorestown, that's why I used such a name.
> Anyway, we can discuss more about it.

Then the way to structure it is the classic "bus glue plus core".

Core would be a "designware_spi" (or, "dw_spi" by analogy to the
"dw_dmac" DMA driver).  It would either expose private calls to
bus glue -- PCI or APB, I guess -- or would be a platform_bus thing
with the PCI glue creating a platform_bus child of a PCI node.

- Dave


------------------------------------------------------------------------------

Re: [PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platform

[Tang, Feng]

>-----Original Message-----
>From: David Brownell [mailto:david-b@pacbell.net]
>Sent: 2009年6月24日 10:10
>To: Tang, Feng; Baruch Siach
>Cc: spi-devel-general@lists.sourceforge.net; akpm@linux-foundation.org;
>alan@lxorguk.ukuu.org.uk
>Subject: Re: [spi-devel-general] [PATCH 0/2] spi: add driver for SPI controller of Intel
>Moorestown platform
>
>On Monday 15 June 2009, Tang, Feng wrote:
>> >>
>> >> User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
>> >
>> >Wow. This is a big surprise for me. I was working on a driver of the Synopsys
>> >Designware SPI controller myself during the last year. I posted my work on
>> >this list and got reviews from Linus Walleij. No word from David Brownell yet.
>> >I'll look into your work and see whether we can merge the drivers.
>>
>> Good idea, we can work together to make the driver better.
>>
>> Regarding the driver name, it is implemented as a PCI device driver, also it has
>> some Moorestown specific stuff like DMA operation, DMA part of the driver only
>> works with the DMA controller on Moorestown, that's why I used such a name.
>> Anyway, we can discuss more about it.
>
>Then the way to structure it is the classic "bus glue plus core".
>
>Core would be a "designware_spi" (or, "dw_spi" by analogy to the
>"dw_dmac" DMA driver).  It would either expose private calls to
>bus glue -- PCI or APB, I guess -- or would be a platform_bus thing
>with the PCI glue creating a platform_bus child of a PCI node.

Thanks for the suggestion, will take a look at it

- Feng.

>
>- Dave

------------------------------------------------------------------------------
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general