* [RFC, PATCH 2/2] SPI: orion_spi: accept zero clock speed
@ 2008-09-16 13:28 Lennert Buytenhek
[not found] ` <20080916132843.GB19493-mfnYTeDhw6uOVk/H6u/4e9i2O/JbrIOy@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Lennert Buytenhek @ 2008-09-16 13:28 UTC (permalink / raw)
To: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Cc: shadi-eYqpPyKDWXRBDgjK7y7TUQ, nico-mo2vmkxb4K0,
saeed-eYqpPyKDWXRBDgjK7y7TUQ
Signed-off-by: Lennert Buytenhek <buytenh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
diff --git a/drivers/spi/orion_spi.c b/drivers/spi/orion_spi.c
index e33412a..014becb 100644
--- a/drivers/spi/orion_spi.c
+++ b/drivers/spi/orion_spi.c
@@ -432,7 +432,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m)
goto msg_rejected;
}
- if (t->speed_hz < orion_spi->min_speed) {
+ if (t->speed_hz && t->speed_hz < orion_spi->min_speed) {
dev_err(&spi->dev,
"message rejected : "
"device min speed (%d Hz) exceeds "
--
1.5.6.4
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC, PATCH 2/2] SPI: orion_spi: accept zero clock speed
[not found] ` <20080916132843.GB19493-mfnYTeDhw6uOVk/H6u/4e9i2O/JbrIOy@public.gmane.org>
@ 2008-09-16 13:43 ` Saeed Bishara
0 siblings, 0 replies; 2+ messages in thread
From: Saeed Bishara @ 2008-09-16 13:43 UTC (permalink / raw)
To: Lennert Buytenhek, dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: Shadi Ammouri, nico-mo2vmkxb4K0
>
> - if (t->speed_hz < orion_spi->min_speed) {
> + if (t->speed_hz && t->speed_hz < orion_spi->min_speed) {
> dev_err(&spi->dev,
> "message rejected : "
> "device min speed (%d Hz) exceeds "
Agree, when speed_hz is zero then max_speed should be used.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-16 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-16 13:28 [RFC, PATCH 2/2] SPI: orion_spi: accept zero clock speed Lennert Buytenhek
[not found] ` <20080916132843.GB19493-mfnYTeDhw6uOVk/H6u/4e9i2O/JbrIOy@public.gmane.org>
2008-09-16 13:43 ` Saeed Bishara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).