* [PATCH -next] spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe()
@ 2023-02-17 7:52 Yang Yingliang
2023-02-20 22:51 ` William Zhang
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2023-02-17 7:52 UTC (permalink / raw)
To: linux-spi
Cc: william.zhang, kursad.oney, jonas.gorski,
bcm-kernel-feedback-list, broonie, yangyingliang, liwei391
Set the error code when sysfs_create_group() fails in bcmbca_hsspi_probe().
Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/spi/spi-bcm63xx-hsspi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
index 68093c045e0b..cd0a6478f5e7 100644
--- a/drivers/spi/spi-bcm63xx-hsspi.c
+++ b/drivers/spi/spi-bcm63xx-hsspi.c
@@ -849,7 +849,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
- if (sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group)) {
+ ret = sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
+ if (ret) {
dev_err(&pdev->dev, "couldn't register sysfs group\n");
goto out_pm_disable;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe()
2023-02-17 7:52 [PATCH -next] spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe() Yang Yingliang
@ 2023-02-20 22:51 ` William Zhang
0 siblings, 0 replies; 2+ messages in thread
From: William Zhang @ 2023-02-20 22:51 UTC (permalink / raw)
To: Yang Yingliang, linux-spi
Cc: kursad.oney, jonas.gorski, bcm-kernel-feedback-list, broonie, liwei391
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
Hi Yingliang,
On 02/16/2023 11:52 PM, Yang Yingliang wrote:
> Set the error code when sysfs_create_group() fails in bcmbca_hsspi_probe().
>
> Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/spi/spi-bcm63xx-hsspi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
> index 68093c045e0b..cd0a6478f5e7 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -849,7 +849,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
>
> pm_runtime_enable(&pdev->dev);
>
> - if (sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group)) {
> + ret = sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
> + if (ret) {
> dev_err(&pdev->dev, "couldn't register sysfs group\n");
> goto out_pm_disable;
> }
>
Thanks for the patch but this issue was previously fixed with this
patch: https://lore.kernel.org/all/Y+zmoGH6LubPhiI0@kili/
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-20 22:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 7:52 [PATCH -next] spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe() Yang Yingliang
2023-02-20 22:51 ` William Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).