* [PATCH] staging: rtl8192e: Fix BRACES warning
@ 2023-05-24 4:00 David Tadokoro
2023-05-28 9:10 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: David Tadokoro @ 2023-05-24 4:00 UTC (permalink / raw)
To: gregkh; +Cc: David Tadokoro, linux-staging, linux-kernel
Fix checkpatch warning "braces {} are not necessary for single statement
blocks".
Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 4b0ebe96302e..ea993cbb7bf7 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -1099,9 +1099,8 @@ static bool _rtl92e_set_rf_power_state(struct net_device *dev,
break;
}
- if (bResult) {
+ if (bResult)
priv->rtllib->rf_power_state = rf_power_state;
- }
priv->set_rf_pwr_state_in_progress = false;
return bResult;
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix BRACES warning
2023-05-24 4:00 [PATCH] staging: rtl8192e: Fix BRACES warning David Tadokoro
@ 2023-05-28 9:10 ` Greg KH
2023-05-28 15:27 ` David de Barros Tadokoro
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2023-05-28 9:10 UTC (permalink / raw)
To: David Tadokoro; +Cc: linux-staging, linux-kernel
On Wed, May 24, 2023 at 01:00:51AM -0300, David Tadokoro wrote:
> Fix checkpatch warning "braces {} are not necessary for single statement
> blocks".
Why do you have "BRACES" in the subject line as all caps? Where did
that term come from?
No need to shout :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix BRACES warning
2023-05-28 9:10 ` Greg KH
@ 2023-05-28 15:27 ` David de Barros Tadokoro
0 siblings, 0 replies; 3+ messages in thread
From: David de Barros Tadokoro @ 2023-05-28 15:27 UTC (permalink / raw)
To: Greg KH; +Cc: linux-staging, linux-kernel
> On 28 May 2023, at 06:10, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, May 24, 2023 at 01:00:51AM -0300, David Tadokoro wrote:
>> Fix checkpatch warning "braces {} are not necessary for single statement
>> blocks".
>
> Why do you have "BRACES" in the subject line as all caps? Where did
> that term come from?
>
> No need to shout :)
>
> thanks,
>
> greg k-h
Hi, Greg
Thanks so much for your feedback.
You are right, this commit message is horrible. I based it on
a previous commit that cleaned the same warning instead of writing a good commit message myself. Going to fix that.
Sorry for the mess ;)
Many regards,
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-28 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-24 4:00 [PATCH] staging: rtl8192e: Fix BRACES warning David Tadokoro
2023-05-28 9:10 ` Greg KH
2023-05-28 15:27 ` David de Barros Tadokoro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).