Re: [PATCH 3/3] ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable usb_otg

[Chen-Yu Tsai <wens@csie.org>]

On Thu, Jul 1, 2021 at 10:37 PM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Thu,  1 Jul 2021 09:50:09 +0800
> qianfanguijin@163.com wrote:
>
> Hi,
>
> > From: qianfan Zhao <qianfanguijin@163.com>
> >
> > Enable it.
> >
> > Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
> > ---
> >  arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > index a6a1087a0c9b..072535b383b5 100644
> > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > @@ -43,6 +43,7 @@
> >
> >  /dts-v1/;
> >  #include "sun8i-r40.dtsi"
> > +#include "sunxi-common-regulators.dtsi"
> >
> >  #include <dt-bindings/gpio/gpio.h>
> >
> > @@ -299,6 +300,11 @@
> >       regulator-name = "vdd1v2-sata";
> >  };
> >
> > +&reg_usb0_vbus {
> > +     gpio = <&pio 8 13 GPIO_ACTIVE_HIGH>; /* PI13 */
> > +     status = "okay";
> > +};
>
> So there is the same USB0-DRVVBUS signal connected to this GPIO, but
> also to the AXP's N_VBUSEN line.
>
> Not sure if that means either of them can control the voltage?

It's better to use N_VBUSEN if that is connected. Since the PMIC
may have that pin already enabled, it can cause issues with VBUS
input not being correctly used.

ChenYu

> > +
> >  &tcon_tv0 {
> >       status = "okay";
> >  };
> > @@ -328,7 +334,15 @@
> >       };
> >  };
> >
> > +&usb_otg {
> > +     dr_mode = "peripheral";
>
> That should be "otg", since we have a working ID pin and can control
> VBUS.
>
> > +     status = "okay";
> > +};
> > +
> >  &usbphy {
> > +     usb0_id_det-gpios = <&pio 8 4 GPIO_ACTIVE_HIGH>; /* PI4 */
> > +     usb0_vbus_det-gpios = <&pio 8 8 GPIO_ACTIVE_HIGH>; /* PH8 */
>
> The comment should say PI8.
>
> I don't have the board, but can at least confirm that the GPIO pins
> (PI4, PI8 and PI13) match the schematic.
>
> Cheers,
> Andre
>
> > +     usb0_vbus-supply = <&reg_usb0_vbus>;
> >       usb1_vbus-supply = <&reg_vcc5v0>;
> >       usb2_vbus-supply = <&reg_vcc5v0>;
> >       status = "okay";
>