Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Marc Dietrich <marvin24@posteo.de>]

Hi Rohit,

On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:

> On 24/07/20 1:58 pm, Greg KH wrote:
>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>> changed usage of slave (deprecated) to secondary
>>>>
>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>> ---
>>>> v3: change patch subject, add version history
>>>> v2: add changelog text in body of mail
>>>> v1: fix style issues by changing usage of slave to secondary
>>>>
>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>> index 360ec0407740..5d7b66719a39 100644
>>>> --- a/drivers/staging/nvec/nvec.c
>>>> +++ b/drivers/staging/nvec/nvec.c
>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>>>  	return IRQ_HANDLED;
>>>>  }
>>>>
>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>  {
>>>>  	u32 val;
>>>>
>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>  }
>>>>
>>>>  #ifdef CONFIG_PM_SLEEP
>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>  {
>>>>  	disable_irq(nvec->irq);
>>>>  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>  	platform_set_drvdata(pdev, nvec);
>>>>  	nvec->dev = dev;
>>>>
>>>> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>>>> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>>>>  		dev_err(dev, "no i2c address specified");
>>>>  		return -ENODEV;
>>>>  	}

as Christoph said, please don't change this line.

>>>> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>  	}
>>>>  	disable_irq(nvec->irq);
>>>>
>>>> -	tegra_init_i2c_slave(nvec);
>>>> +	tegra_init_i2c_secondary(nvec);
>>>>
>>>>  	/* enable event reporting */
>>>>  	nvec_toggle_global_events(nvec, true);
>>>> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
>>>>  	if (!err)
>>>>  		nvec_msg_free(nvec, msg);
>>>>
>>>> -	nvec_disable_i2c_slave(nvec);
>>>> +	nvec_disable_i2c_secondary(nvec);
>>>>
>>>>  	return 0;
>>>>  }
>>>> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
>>>>  	struct nvec_chip *nvec = dev_get_drvdata(dev);
>>>>
>>>>  	dev_dbg(nvec->dev, "resuming\n");
>>>> -	tegra_init_i2c_slave(nvec);
>>>> +	tegra_init_i2c_secondary(nvec);
>>>>  	nvec_toggle_global_events(nvec, true);
>>>>
>>>>  	return 0;
>>>>
>>> Dear All, this message was not delivered to marvin24@gmx.de, I'm getting that The response from the remote server was:
>>> 554 gmx.net (mxgmx016) Nemesis ESMTP Service not available No SMTP service Reject due to policy restrictions,
>>
>> Not a big deal, email address atrophy over time.  That's why you always
>> cc: a public mailing list for patches.

yes, my mail provider introduces a bit too aggressive mail filtering 
recently, causing me being unsubscribed frequently. I just changed my subscriber 
address, which should fix the problem, sorry.

Marc