linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@posteo.de>
To: Marc Dietrich <marvin24@posteo.de>
Cc: Rohit Bharadwaj <bharadwaj.rohit8@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	p.zabel@pengutronix.de, linux-tegra@vger.kernel.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCH v3] staging: nvec: change usage of slave to secondary
Date: Fri, 24 Jul 2020 18:36:36 +0200 (CEST)	[thread overview]
Message-ID: <alpine.OSX.2.23.453.2007241835260.9201@macbook-pro.fritz.box> (raw)
In-Reply-To: <alpine.OSX.2.23.453.2007241829180.9201@macbook-pro.fritz.box>



On Fri, 24 Jul 2020, Marc Dietrich wrote:

> Hi Rohit,
>
> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
>
>> On 24/07/20 1:58 pm, Greg KH wrote:
>>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>>> changed usage of slave (deprecated) to secondary
>>>>> 
>>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>>> ---
>>>>> v3: change patch subject, add version history
>>>>> v2: add changelog text in body of mail
>>>>> v1: fix style issues by changing usage of slave to secondary
>>>>>
>>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>> 
>>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>>> index 360ec0407740..5d7b66719a39 100644
>>>>> --- a/drivers/staging/nvec/nvec.c
>>>>> +++ b/drivers/staging/nvec/nvec.c
>>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void 
>>>>> *dev)
>>>>>  	return IRQ_HANDLED;
>>>>>  }
>>>>> 
>>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>>  {
>>>>>  	u32 val;
>>>>> 
>>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip 
>>>>> *nvec)
>>>>>  }
>>>>>
>>>>>  #ifdef CONFIG_PM_SLEEP
>>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>>  {
>>>>>  	disable_irq(nvec->irq);
>>>>>  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device 
>>>>> *pdev)
>>>>>  	platform_set_drvdata(pdev, nvec);
>>>>>  	nvec->dev = dev;
>>>>> 
>>>>> -	if (of_property_read_u32(dev->of_node, "slave-addr", 
>>>>> &nvec->i2c_addr)) {
>>>>> +	if (of_property_read_u32(dev->of_node, "secondary-addr", 
>>>>> &nvec->i2c_addr)) {
>>>>>  		dev_err(dev, "no i2c address specified");
>>>>>  		return -ENODEV;
>>>>>  	}
>
> as Christoph said, please don't change this line.

arr, I meant Dan of course ;-)

  reply	other threads:[~2020-07-24 16:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 15:15 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
     [not found] ` <20200723151511.22193-1-bharadwaj.rohit8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-23 17:06   ` Greg KH
     [not found]     ` <20200723170618.GA2835510-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2020-07-24  4:55       ` Rohit Bharadwaj
2020-07-24  4:36   ` [PATCH v3] staging: nvec: change usage of slave to secondary Rohit K Bharadwaj
2020-07-24  8:14     ` Rohit Bharadwaj
2020-07-24  8:28       ` Greg KH
2020-07-24  8:35         ` Rohit Bharadwaj
2020-07-24 16:33           ` Marc Dietrich
2020-07-24 16:36             ` Marc Dietrich [this message]
2020-07-24 16:57               ` Rohit K Bharadwaj
2020-07-24 20:42                 ` Marc Dietrich
2020-07-25  6:50                   ` Rohit K Bharadwaj
2020-07-24 14:09     ` Dan Carpenter
2020-07-24 15:51       ` Rohit K Bharadwaj
2020-07-24 16:23         ` Greg KH
2020-07-25  6:29     ` [PATCH v4] " Rohit K Bharadwaj
2020-07-25 12:01       ` Michał Mirosław
2020-07-25 12:31         ` Rohit K Bharadwaj
2020-07-25 12:50           ` Michał Mirosław
2020-07-25 13:02             ` Rohit K Bharadwaj
2020-08-02  8:07             ` Marc Dietrich
2020-08-02  8:13       ` Marc Dietrich
2020-08-02  9:09         ` Rohit K Bharadwaj
2020-07-24 14:07 ` [PATCH] change slave occurence to secondary everywhere Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.23.453.2007241835260.9201@macbook-pro.fritz.box \
    --to=marvin24@posteo.de \
    --cc=bharadwaj.rohit8@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).