From: Steven Rostedt <rostedt@goodmis.org>
To: Patrick McLean <chutzpah@gentoo.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Generate proper soname
Date: Wed, 24 Jul 2019 21:59:07 -0400 [thread overview]
Message-ID: <20190724215907.1534511f@oasis.local.home> (raw)
In-Reply-To: <20190725014808.3646716-1-chutzpah@gentoo.org>
On Wed, 24 Jul 2019 18:48:08 -0700
Patrick McLean <chutzpah@gentoo.org> wrote:
> From: Patrick McLean <patrick.mclean@sony.com>
>
> The previous soname patch was an earlier version that included the full
> path to the build output as the soname (not sure how that happened).
> This just uses the basename as the soname, so ld will be able to
> properly find the library.
Ah, so now I need to release a 2.8.4?
Thanks, ;-)
I'll wait till Friday before adding a 2.8.4.
-- Steve
> ---
> scripts/utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/utils.mk b/scripts/utils.mk
> index 9eb127d..98d7b3c 100644
> --- a/scripts/utils.mk
> +++ b/scripts/utils.mk
> @@ -54,7 +54,7 @@ do_build_static_lib = \
>
> do_compile_shared_library = \
> ($(print_shared_lib_compile) \
> - $(CC) --shared $^ -Wl,-soname,$@ -o $@)
> + $(CC) --shared $^ -Wl,-soname,$(@F) -o $@)
>
> do_compile_plugin_obj = \
> ($(print_plugin_obj_compile) \
next prev parent reply other threads:[~2019-07-25 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 1:48 [PATCH] trace-cmd: Generate proper soname Patrick McLean
2019-07-25 1:59 ` Steven Rostedt [this message]
2019-07-25 12:49 ` Steven Rostedt
2019-07-25 17:08 ` Patrick McLean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724215907.1534511f@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=chutzpah@gentoo.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).