From: Patrick McLean <chutzpah@gentoo.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Generate proper soname
Date: Thu, 25 Jul 2019 10:08:37 -0700 [thread overview]
Message-ID: <20190725100837.5bd4ce96@patrickm> (raw)
In-Reply-To: <20190725084932.43e05c27@gandalf.local.home>
On Thu, 25 Jul 2019 08:49:32 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 24 Jul 2019 18:48:08 -0700
> Patrick McLean <chutzpah@gentoo.org> wrote:
>
> > From: Patrick McLean <patrick.mclean@sony.com>
> >
> > The previous soname patch was an earlier version that included the
> > full path to the build output as the soname (not sure how that
> > happened). This just uses the basename as the soname, so ld will be
> > able to properly find the library.
>
> Hi Patrick,
>
> You forgot to add the Signed-off-by, can you reply to this with one.
> Thanks. I can't add it without it.
>
My apologies.
> -- Steve
>
Signed-off-by: Patrick McLean <patrick.mclean@sony.com>
> > ---
> > scripts/utils.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/utils.mk b/scripts/utils.mk
> > index 9eb127d..98d7b3c 100644
> > --- a/scripts/utils.mk
> > +++ b/scripts/utils.mk
> > @@ -54,7 +54,7 @@ do_build_static_lib
> > = \
> > do_compile_shared_library = \
> > ($(print_shared_lib_compile) \
> > - $(CC) --shared $^ -Wl,-soname,$@ -o $@)
> > + $(CC) --shared $^ -Wl,-soname,$(@F) -o $@)
> >
> > do_compile_plugin_obj = \
> > ($(print_plugin_obj_compile) \
>
prev parent reply other threads:[~2019-07-25 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 1:48 [PATCH] trace-cmd: Generate proper soname Patrick McLean
2019-07-25 1:59 ` Steven Rostedt
2019-07-25 12:49 ` Steven Rostedt
2019-07-25 17:08 ` Patrick McLean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725100837.5bd4ce96@patrickm \
--to=chutzpah@gentoo.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).