From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v20 09/15] trace-cmd: Implement new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT
Date: Thu, 27 Feb 2020 12:28:01 -0500 [thread overview]
Message-ID: <20200227122801.4e067f90@gandalf.local.home> (raw)
In-Reply-To: <20200227142001.61577-10-tz.stoyanov@gmail.com>
On Thu, 27 Feb 2020 16:19:55 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> + case TRACECMD_OPTION_TIME_SHIFT:
> + /*
> + * long long int (8 bytes) trace session ID
> + * int (4 bytes) count of timestamp offsets.
> + * long long array of size [count] of times,
> + * when the offsets were calculated.
> + * long long array of size [count] of timestamp offsets.
> + */
> + if (size < 12 || handle->flags & TRACECMD_FL_IGNORE_DATE)
> + break;
> + handle->host.trace_id = tep_read_number(handle->pevent,
> + buf, 8);
> + handle->host.ts_samples_count = tep_read_number(handle->pevent,
> + buf + 8, 4);
> + samples_size = (8 * handle->host.ts_samples_count);
> + if (size != (12 + (2 * samples_size))) {
> + warning("Failed to extract Time Shift information from the file, unexpected size %d", size);
Probably should show what was expected as well.
warning("Failed to extract Time Shift information from the file: found size %d but expected %d",
size, 12 + (2 * samples_size));
-- Steve
> + break;
> + }
> + handle->host.ts_samples = malloc(2 * samples_size);
> + if (!handle->host.ts_samples)
> + return -ENOMEM;
> + tsync_offset_load(handle, buf + 12);
> + break;
next prev parent reply other threads:[~2020-02-27 17:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:19 [PATCH v20 00/15]Timestamp synchronization of host - guest tracing session Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 01/15] trace-cmd: Add support for negative time offsets in trace.dat file Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 02/15] trace-cmd: Add new library API for local CPU count Tzvetomir Stoyanov (VMware)
2020-02-28 23:42 ` Steven Rostedt
2020-02-27 14:19 ` [PATCH v20 03/15] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Tzvetomir Stoyanov (VMware)
2020-02-27 17:23 ` Steven Rostedt
2020-03-02 9:29 ` Tzvetomir Stoyanov
2020-02-27 14:19 ` [PATCH v20 04/15] trace-cmd: Implement new API tracecmd_add_option_v() Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 05/15] trace-cmd: Add new API to generate a unique ID of the tracing session Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 06/15] trace-cmd: Store the session tracing ID in the trace.dat file Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 07/15] trace-cmd: Add definitions of htonll() and ntohll() Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 08/15] trace-cmd: Exchange tracing IDs between host and guest Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 09/15] trace-cmd: Implement new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Tzvetomir Stoyanov (VMware)
2020-02-27 17:28 ` Steven Rostedt [this message]
2020-02-27 14:19 ` [PATCH v20 10/15] trace-cmd: Add guest information in host's trace.dat file Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 11/15] trace-cmd: Add host trace clock as guest trace argument Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 12/15] trace-cmd: Refactor few trace-cmd internal functions Tzvetomir Stoyanov (VMware)
2020-02-27 14:19 ` [PATCH v20 13/15] trace-cmd: Basic infrastructure for host - guest timestamp synchronization Tzvetomir Stoyanov (VMware)
2020-02-28 17:41 ` Steven Rostedt
2020-02-29 0:28 ` Steven Rostedt
2020-03-02 9:43 ` Tzvetomir Stoyanov
2020-03-02 13:43 ` Steven Rostedt
2020-02-27 14:20 ` [PATCH v20 14/15] trace-cmd: [POC] PTP-like algorithm " Tzvetomir Stoyanov (VMware)
2020-02-27 14:20 ` [PATCH v20 15/15] trace-cmd: Debug scripts for " Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227122801.4e067f90@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).