* [PATCH] trace-cmd: Fix trace-cmd split command
@ 2021-03-02 10:16 Tzvetomir Stoyanov (VMware)
0 siblings, 0 replies; only message in thread
From: Tzvetomir Stoyanov (VMware) @ 2021-03-02 10:16 UTC (permalink / raw)
To: rostedt; +Cc: linux-trace-devel
The trace-cmd split command seems to be broken with the changes moving
the writing of saved_cmdlines after the trace session.
The call to tracecmd_write_cmdlines() is no more needed in this command
context, the cmdlines should be copied from input to output files.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
This patch depends on "trace-cmd: Fixes for trace-cmd restore" patch set.
tracecmd/trace-split.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c
index 7c9863d4..8366d128 100644
--- a/tracecmd/trace-split.c
+++ b/tracecmd/trace-split.c
@@ -384,10 +384,6 @@ static double parse_file(struct tracecmd_input *handle,
for (cpu = 0; cpu < cpus; cpu ++)
cpu_list[cpu] = cpu_data[cpu].file;
- /* TODO: Fix me, this is suppose to come from handle */
- if (tracecmd_write_cmdlines(ohandle))
- die("Writing cmdlines");
-
tracecmd_append_cpu_data(ohandle, cpus, cpu_list);
current = end;
--
2.29.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-03 0:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 10:16 [PATCH] trace-cmd: Fix trace-cmd split command Tzvetomir Stoyanov (VMware)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).