From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v3 03/10] ovl: implement ->writepages operation
Date: Sun, 8 Nov 2020 22:03:00 +0800 [thread overview]
Message-ID: <20201108140307.1385745-4-cgxu519@mykernel.net> (raw)
In-Reply-To: <20201108140307.1385745-1-cgxu519@mykernel.net>
Implement overlayfs' ->writepages operation so that
we can sync dirty data/metadata to upper filesystem.
If writeback mode is sync_mode we add overlayfs inode
to extra syncfs wait list so that we can wait completion
in ->syncfs.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/overlayfs/inode.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index b584dca845ba..1f5cbbc60b28 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -11,6 +11,7 @@
#include <linux/posix_acl.h>
#include <linux/ratelimit.h>
#include <linux/fiemap.h>
+#include <linux/writeback.h>
#include "overlayfs.h"
@@ -516,7 +517,30 @@ static const struct inode_operations ovl_special_inode_operations = {
.update_time = ovl_update_time,
};
+static int ovl_writepages(struct address_space *mapping,
+ struct writeback_control *wbc)
+{
+ struct inode *inode = mapping->host;
+ struct ovl_fs *ofs = inode->i_sb->s_fs_info;
+ struct inode *upper = ovl_inode_upper(inode);
+ int ret;
+
+ if (!ovl_should_sync(ofs))
+ return 0;
+ ret = sync_inode(upper, wbc);
+ if (!ret && wbc->for_sync == 1) {
+ spin_lock(&ofs->syncfs_wait_list_lock);
+ if (list_empty(&OVL_I(inode)->wait_list))
+ list_add_tail(&OVL_I(inode)->wait_list,
+ &ofs->syncfs_wait_list);
+ spin_unlock(&ofs->syncfs_wait_list_lock);
+ }
+
+ return ret;
+}
+
static const struct address_space_operations ovl_aops = {
+ .writepages = ovl_writepages,
/* For O_DIRECT dentry_open() checks f_mapping->a_ops->direct_IO */
.direct_IO = noop_direct_IO,
};
--
2.26.2
next prev parent reply other threads:[~2020-11-08 14:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 14:02 [RFC PATCH v3 00/10] implement containerized syncfs for overlayfs Chengguang Xu
2020-11-08 14:02 ` [RFC PATCH v3 01/10] ovl: setup overlayfs' private bdi Chengguang Xu
2020-11-08 14:02 ` [RFC PATCH v3 02/10] ovl: introduce waiting list for syncfs Chengguang Xu
2020-11-08 14:03 ` Chengguang Xu [this message]
2020-11-08 14:03 ` [RFC PATCH v3 04/10] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 05/10] ovl: mark overlayfs' inode dirty on modification Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 06/10] ovl: mark overlayfs' inode dirty on shared mmap Chengguang Xu
2020-11-11 13:05 ` 回复:[RFC " Chengguang Xu
2020-11-11 15:20 ` [RFC " Amir Goldstein
2020-11-11 16:09 ` Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 07/10] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2020-11-10 13:45 ` Jan Kara
2020-11-10 15:12 ` Chengguang Xu
2020-11-11 10:54 ` Jan Kara
2020-11-10 16:18 ` Amir Goldstein
2020-11-08 14:03 ` [RFC PATCH v3 08/10] ovl: cache dirty overlayfs' inode Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 09/10] ovl: introduce helper of syncfs writeback inode waiting Chengguang Xu
2020-11-09 3:33 ` 回复:[RFC " Chengguang Xu
2020-11-09 7:07 ` [RFC " Amir Goldstein
2020-11-09 8:34 ` Chengguang Xu
2020-11-09 10:07 ` Amir Goldstein
2020-11-09 12:06 ` Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 10/10] ovl: implement containerized syncfs for overlayfs Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108140307.1385745-4-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).