From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v3 07/10] ovl: implement overlayfs' ->write_inode operation
Date: Sun, 8 Nov 2020 22:03:04 +0800 [thread overview]
Message-ID: <20201108140307.1385745-8-cgxu519@mykernel.net> (raw)
In-Reply-To: <20201108140307.1385745-1-cgxu519@mykernel.net>
Implement overlayfs' ->write_inode to sync dirty data
and redirty overlayfs' inode if necessary.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/overlayfs/super.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 694eff76eb09..0ddee18b0bab 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -391,6 +391,35 @@ static int ovl_remount(struct super_block *sb, int *flags, char *data)
return ret;
}
+static int ovl_write_inode(struct inode *inode,
+ struct writeback_control *wbc)
+{
+ struct ovl_fs *ofs = inode->i_sb->s_fs_info;
+ struct inode *upper = ovl_inode_upper(inode);
+ unsigned long iflag = 0;
+ int ret = 0;
+
+ if (!upper)
+ return 0;
+
+ if (!ovl_should_sync(ofs))
+ return 0;
+
+ if (upper->i_sb->s_op->write_inode)
+ ret = upper->i_sb->s_op->write_inode(inode, wbc);
+
+ iflag |= upper->i_state & I_DIRTY_ALL;
+
+ if (mapping_writably_mapped(upper->i_mapping) ||
+ mapping_tagged(upper->i_mapping, PAGECACHE_TAG_WRITEBACK))
+ iflag |= I_DIRTY_PAGES;
+
+ if (iflag)
+ ovl_mark_inode_dirty(inode);
+
+ return ret;
+}
+
static void ovl_evict_inode(struct inode *inode)
{
struct ovl_fs *ofs = inode->i_sb->s_fs_info;
@@ -411,6 +440,7 @@ static const struct super_operations ovl_super_operations = {
.destroy_inode = ovl_destroy_inode,
.drop_inode = generic_delete_inode,
.evict_inode = ovl_evict_inode,
+ .write_inode = ovl_write_inode,
.put_super = ovl_put_super,
.sync_fs = ovl_sync_fs,
.statfs = ovl_statfs,
--
2.26.2
next prev parent reply other threads:[~2020-11-08 14:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 14:02 [RFC PATCH v3 00/10] implement containerized syncfs for overlayfs Chengguang Xu
2020-11-08 14:02 ` [RFC PATCH v3 01/10] ovl: setup overlayfs' private bdi Chengguang Xu
2020-11-08 14:02 ` [RFC PATCH v3 02/10] ovl: introduce waiting list for syncfs Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 03/10] ovl: implement ->writepages operation Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 04/10] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 05/10] ovl: mark overlayfs' inode dirty on modification Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 06/10] ovl: mark overlayfs' inode dirty on shared mmap Chengguang Xu
2020-11-11 13:05 ` 回复:[RFC " Chengguang Xu
2020-11-11 15:20 ` [RFC " Amir Goldstein
2020-11-11 16:09 ` Chengguang Xu
2020-11-08 14:03 ` Chengguang Xu [this message]
2020-11-10 13:45 ` [RFC PATCH v3 07/10] ovl: implement overlayfs' ->write_inode operation Jan Kara
2020-11-10 15:12 ` Chengguang Xu
2020-11-11 10:54 ` Jan Kara
2020-11-10 16:18 ` Amir Goldstein
2020-11-08 14:03 ` [RFC PATCH v3 08/10] ovl: cache dirty overlayfs' inode Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 09/10] ovl: introduce helper of syncfs writeback inode waiting Chengguang Xu
2020-11-09 3:33 ` 回复:[RFC " Chengguang Xu
2020-11-09 7:07 ` [RFC " Amir Goldstein
2020-11-09 8:34 ` Chengguang Xu
2020-11-09 10:07 ` Amir Goldstein
2020-11-09 12:06 ` Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 10/10] ovl: implement containerized syncfs for overlayfs Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108140307.1385745-8-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).