From: Sanjay R Mehta <Sanju.Mehta@amd.com>
To: <mika.westerberg@linux.intel.com>, <andreas.noever@gmail.com>,
<michael.jamet@intel.com>, <YehezkelShB@gmail.com>
Cc: <Basavaraj.Natikar@amd.com>, <linux-usb@vger.kernel.org>,
Sanjay R Mehta <sanju.mehta@amd.com>
Subject: [PATCH v2 3/4] thunderbolt: Skip port init for control adapter(0)
Date: Tue, 3 Aug 2021 07:34:55 -0500 [thread overview]
Message-ID: <1627994096-99972-4-git-send-email-Sanju.Mehta@amd.com> (raw)
In-Reply-To: <1627994096-99972-1-git-send-email-Sanju.Mehta@amd.com>
From: Sanjay R Mehta <sanju.mehta@amd.com>
Adapter (0) is control adapter and as per USB4 spec in "Section 1.8",
Control Adapters do not have an Adapter Configuration Space".
Hence skip port initialization for adapter (0).
Fixes: e6b245ccd524 ("thunderbolt: Add support for host and device NVM firmware upgrade")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
---
drivers/thunderbolt/switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index 83b1ef3..6447876 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -2740,7 +2740,7 @@ int tb_switch_add(struct tb_switch *sw)
return ret;
}
- for (i = 0; i <= sw->config.max_port_number; i++) {
+ for (i = 1; i <= sw->config.max_port_number; i++) {
if (sw->ports[i].disabled) {
tb_port_dbg(&sw->ports[i], "disabled by eeprom\n");
continue;
--
2.7.4
next prev parent reply other threads:[~2021-08-03 12:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 12:34 [PATCH v2 0/4] Added some bug fixes for USB4 Sanjay R Mehta
2021-08-03 12:34 ` [PATCH v2 1/4] thunderbolt: Intel controller uses BIT(2) for intr auto Sanjay R Mehta
2021-08-03 12:34 ` [PATCH v2 2/4] thunderbolt: Handle ring interrupt by reading intr status Sanjay R Mehta
2021-08-04 15:48 ` Mika Westerberg
2021-08-05 12:56 ` Mika Westerberg
2021-08-05 13:06 ` Sanjay R Mehta
2021-08-05 14:20 ` Mika Westerberg
2021-08-05 12:59 ` Sanjay R Mehta
2021-08-05 14:19 ` Mika Westerberg
2021-08-05 14:46 ` Mika Westerberg
2021-08-05 18:03 ` Sanjay R Mehta
2021-08-03 12:34 ` Sanjay R Mehta [this message]
2021-08-03 12:34 ` [PATCH v2 4/4] thunderbolt: Fix port linking by checking all adapters Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1627994096-99972-4-git-send-email-Sanju.Mehta@amd.com \
--to=sanju.mehta@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).