linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Stratton Treadway <vgerlists@nathanst.com>
To: linux-usb@vger.kernel.org
Subject: Adding "UAS" protocol line to usb.ids file?
Date: Sat, 17 Aug 2019 18:01:45 -0400	[thread overview]
Message-ID: <20190817220145.GJ1403@nathanst.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2257 bytes --]

I noticed that when I use "lsusb -v" on a UAS-enabled drive enclosure,
the bInterfaceProtocol line for #80/0x50 has a "protocol name" label but the
one for #98/0x62 does not:


========
# lsusb -v -s2:15 | grep Interface
  bDeviceClass            0 (Defined at Interface level)
    bNumInterfaces          1
    Interface Descriptor:
      bInterfaceNumber        0
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     80 Bulk-Only
      iInterface              0
    Interface Descriptor:
      bInterfaceNumber        0
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     98
      iInterface              0
========



So...I was wondering if there was any particular reason that protocol
98 isn't included in the usb.ids file?


As a proof of concept I added the SCSI-subclass version of the line to
the usb.ids file (see attached patch) and lsusb successfully showed a
description for the #98 line as well:

========
# lsusb -v -s2:15 | grep Interface
  bDeviceClass            0 (Defined at Interface level)
    bNumInterfaces          1
    Interface Descriptor:
      bInterfaceNumber        0
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     80 Bulk-Only
      iInterface              0
    Interface Descriptor:
      bInterfaceNumber        0
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     98 UAS
      iInterface              0
========

(This experiment was on an Ubuntu Bionic system.)

I searched the list archives (and web in general) for previous
discussion on this topic, but didn't succeed in finding this specific
issue.

(I see that 62 is in fact included in the protocol list found on
  https://usb-ids.gowdy.us/read/UC/08/06
, but it has an empty "name" column in that table -- and it's missing
completely from the current file at
  https://usb-ids.gowdy.us/usb.ids 
.)

Thanks.


							Nathan

p.s. If in fact it makes sense to add UAS to the file: I assume the UAS
protocol doesn't apply to the UFI subclass, but I don't know off hand if
it applies to the RBC subclass as well as SCSI...


[-- Attachment #2: usb.ids_add_uas.patch --]
[-- Type: text/plain, Size: 259 bytes --]

--- usb.ids_orig	2017-04-21 16:59:17.000000000 -0400
+++ usb.ids	2019-08-17 00:05:51.688459268 -0400
@@ -18012,6 +18012,7 @@
 		00  Control/Bulk/Interrupt
 		01  Control/Bulk
 		50  Bulk-Only
+		62  UAS
 C 09  Hub
 	00  Unused
 		00  Full speed (or root) hub

             reply	other threads:[~2019-08-17 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17 22:01 Nathan Stratton Treadway [this message]
2019-09-03 13:39 ` Adding "UAS" protocol line to usb.ids file? Greg KH
2019-09-03 15:43   ` Nathan Stratton Treadway

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190817220145.GJ1403@nathanst.com \
    --to=vgerlists@nathanst.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).