* [PATCH v2 0/2] Add TI tps6598x DT binding and probe
@ 2020-05-07 21:47 Bryan O'Donoghue
2020-05-07 21:47 ` [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation Bryan O'Donoghue
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Bryan O'Donoghue @ 2020-05-07 21:47 UTC (permalink / raw)
To: heikki.krogerus, robh+dt, linux-usb, devicetree
Cc: gregkh, linux-kernel, nikolaus.voss, andriy.shevchenko, garsilva,
keescook, Bryan O'Donoghue
V2:
- Put myself down as sole schema maintainer as suggested - Andy
- Fixed whitespace typo - Andy
- Removed ifdef and of_match_ptr() - Andy
V1:
This simple series adds DT binding yaml and a DT lookup table for the
tps6598x.
Its possible to use i2c id_table to match the 'compatible = "ti,tps6598x"
and probe that way, however I think it is worthwhile adding a specific OF
way of doing it and having an accompanying yaml as an example.
Bryan O'Donoghue (2):
dt-bindings: usb: Add TI tps6598x device tree binding documentation
usb: typec: tps6598x: Add OF probe binding
.../devicetree/bindings/usb/ti,tps6598x.yaml | 64 +++++++++++++++++++
drivers/usb/typec/tps6598x.c | 7 ++
2 files changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation
2020-05-07 21:47 [PATCH v2 0/2] Add TI tps6598x DT binding and probe Bryan O'Donoghue
@ 2020-05-07 21:47 ` Bryan O'Donoghue
2020-05-15 3:09 ` Rob Herring
2020-05-07 21:47 ` [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding Bryan O'Donoghue
2020-05-08 14:01 ` [PATCH v2 0/2] Add TI tps6598x DT binding and probe Heikki Krogerus
2 siblings, 1 reply; 10+ messages in thread
From: Bryan O'Donoghue @ 2020-05-07 21:47 UTC (permalink / raw)
To: heikki.krogerus, robh+dt, linux-usb, devicetree
Cc: gregkh, linux-kernel, nikolaus.voss, andriy.shevchenko, garsilva,
keescook, Bryan O'Donoghue
Add device tree binding documentation for the Texas Instruments tps6598x
Type-C chip driver.
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/usb/ti,tps6598x.yaml | 64 +++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
new file mode 100644
index 000000000000..8eaf4b6c4735
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/usb/ti,tps6598x.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Texas Instruments 6598x Type-C Port Switch and Power Delivery controller DT bindings
+
+maintainers:
+ - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
+
+description: |
+ Texas Instruments 6598x Type-C Port Switch and Power Delivery controller
+
+properties:
+ compatible:
+ enum:
+ - ti,tps6598x
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-names:
+ items:
+ - const: irq
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-names
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tps6598x: tps6598x@38 {
+ compatible = "ti,tps6598x";
+ reg = <0x38>;
+
+ interrupt-parent = <&msmgpio>;
+ interrupts = <107 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "irq";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&typec_pins>;
+
+ typec_con: connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ port {
+ typec_ep: endpoint {
+ remote-endpoint = <&otg_ep>;
+ };
+ };
+ };
+ };
+ };
+...
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding
2020-05-07 21:47 [PATCH v2 0/2] Add TI tps6598x DT binding and probe Bryan O'Donoghue
2020-05-07 21:47 ` [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation Bryan O'Donoghue
@ 2020-05-07 21:47 ` Bryan O'Donoghue
2020-05-09 7:59 ` Martin Kepplinger
2020-05-11 10:29 ` Heikki Krogerus
2020-05-08 14:01 ` [PATCH v2 0/2] Add TI tps6598x DT binding and probe Heikki Krogerus
2 siblings, 2 replies; 10+ messages in thread
From: Bryan O'Donoghue @ 2020-05-07 21:47 UTC (permalink / raw)
To: heikki.krogerus, robh+dt, linux-usb, devicetree
Cc: gregkh, linux-kernel, nikolaus.voss, andriy.shevchenko, garsilva,
keescook, Bryan O'Donoghue
Adds a MODULE_DEVICE_TABLE() to allow probing of this driver from a DTS
setting.
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Gustavo A. R. Silva <garsilva@embeddedor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/usb/typec/tps6598x.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
index 0698addd1185..defa651282b0 100644
--- a/drivers/usb/typec/tps6598x.c
+++ b/drivers/usb/typec/tps6598x.c
@@ -563,6 +563,12 @@ static int tps6598x_remove(struct i2c_client *client)
return 0;
}
+static const struct of_device_id tps6598x_of_match[] = {
+ { .compatible = "ti,tps6598x", },
+ {}
+};
+MODULE_DEVICE_TABLE(of, tps6598x_of_match);
+
static const struct i2c_device_id tps6598x_id[] = {
{ "tps6598x" },
{ }
@@ -572,6 +578,7 @@ MODULE_DEVICE_TABLE(i2c, tps6598x_id);
static struct i2c_driver tps6598x_i2c_driver = {
.driver = {
.name = "tps6598x",
+ .of_match_table = tps6598x_of_match,
},
.probe_new = tps6598x_probe,
.remove = tps6598x_remove,
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/2] Add TI tps6598x DT binding and probe
2020-05-07 21:47 [PATCH v2 0/2] Add TI tps6598x DT binding and probe Bryan O'Donoghue
2020-05-07 21:47 ` [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation Bryan O'Donoghue
2020-05-07 21:47 ` [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding Bryan O'Donoghue
@ 2020-05-08 14:01 ` Heikki Krogerus
2020-05-08 14:22 ` Angus Ainslie
2 siblings, 1 reply; 10+ messages in thread
From: Heikki Krogerus @ 2020-05-08 14:01 UTC (permalink / raw)
To: Bryan O'Donoghue, Angus Ainslie
Cc: robh+dt, linux-usb, devicetree, gregkh, linux-kernel,
nikolaus.voss, andriy.shevchenko, garsilva, keescook
Hi,
On Thu, May 07, 2020 at 10:47:31PM +0100, Bryan O'Donoghue wrote:
> V2:
> - Put myself down as sole schema maintainer as suggested - Andy
> - Fixed whitespace typo - Andy
> - Removed ifdef and of_match_ptr() - Andy
>
> V1:
> This simple series adds DT binding yaml and a DT lookup table for the
> tps6598x.
>
> Its possible to use i2c id_table to match the 'compatible = "ti,tps6598x"
> and probe that way, however I think it is worthwhile adding a specific OF
> way of doing it and having an accompanying yaml as an example.
>
> Bryan O'Donoghue (2):
> dt-bindings: usb: Add TI tps6598x device tree binding documentation
> usb: typec: tps6598x: Add OF probe binding
>
> .../devicetree/bindings/usb/ti,tps6598x.yaml | 64 +++++++++++++++++++
> drivers/usb/typec/tps6598x.c | 7 ++
> 2 files changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
There was already a series from Angus [1] for this. The bindings
looked a bit different, but I think we should use these, because in
the DT bindings from Angus there appeared to be definitions for OF
graph that was not used. Or maybe I got it wrong?
Angus, is it OK if we use these patches instead the ones from you?
[1] https://lore.kernel.org/linux-usb/20200506191718.2144752-1-angus@akkea.ca/
thanks,
--
heikki
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/2] Add TI tps6598x DT binding and probe
2020-05-08 14:01 ` [PATCH v2 0/2] Add TI tps6598x DT binding and probe Heikki Krogerus
@ 2020-05-08 14:22 ` Angus Ainslie
2020-05-08 14:47 ` Bryan O'Donoghue
0 siblings, 1 reply; 10+ messages in thread
From: Angus Ainslie @ 2020-05-08 14:22 UTC (permalink / raw)
To: Heikki Krogerus, Bryan O'Donoghue
Cc: robh+dt, linux-usb, devicetree, gregkh, linux-kernel,
nikolaus.voss, andriy.shevchenko, garsilva, keescook,
linux-usb-owner
Hi,
On 2020-05-08 07:01, Heikki Krogerus wrote:
> Hi,
>
> On Thu, May 07, 2020 at 10:47:31PM +0100, Bryan O'Donoghue wrote:
>> V2:
>> - Put myself down as sole schema maintainer as suggested - Andy
>> - Fixed whitespace typo - Andy
>> - Removed ifdef and of_match_ptr() - Andy
>>
>> V1:
>> This simple series adds DT binding yaml and a DT lookup table for the
>> tps6598x.
>>
>> Its possible to use i2c id_table to match the 'compatible =
>> "ti,tps6598x"
>> and probe that way, however I think it is worthwhile adding a specific
>> OF
>> way of doing it and having an accompanying yaml as an example.
>>
>> Bryan O'Donoghue (2):
>> dt-bindings: usb: Add TI tps6598x device tree binding documentation
>> usb: typec: tps6598x: Add OF probe binding
>>
>> .../devicetree/bindings/usb/ti,tps6598x.yaml | 64
>> +++++++++++++++++++
>> drivers/usb/typec/tps6598x.c | 7 ++
>> 2 files changed, 71 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>
> There was already a series from Angus [1] for this. The bindings
> looked a bit different, but I think we should use these, because in
> the DT bindings from Angus there appeared to be definitions for OF
> graph that was not used. Or maybe I got it wrong?
>
I was trying to include optional components but was not sure of the
syntax so that might have been wrong.
> Angus, is it OK if we use these patches instead the ones from you?
>
Yeah these ones will work great for what we need.
Sorry Bryan I didn't realize there was a patch already in progress.
@Bryan, I'm going to send up some extcon patches for the tps6598x soon
but maybe I should check and make sure you don't already have anything
planned there.
It still needs to be retested after cleaning up but it's the top 9
patches here:
https://source.puri.sm/angus.ainslie/linux-next/-/commits/next/extcon
Thanks
Angus
> [1]
> https://lore.kernel.org/linux-usb/20200506191718.2144752-1-angus@akkea.ca/
>
> thanks,
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/2] Add TI tps6598x DT binding and probe
2020-05-08 14:22 ` Angus Ainslie
@ 2020-05-08 14:47 ` Bryan O'Donoghue
2020-05-08 16:21 ` Angus Ainslie
0 siblings, 1 reply; 10+ messages in thread
From: Bryan O'Donoghue @ 2020-05-08 14:47 UTC (permalink / raw)
To: Angus Ainslie, Heikki Krogerus
Cc: robh+dt, linux-usb, devicetree, gregkh, linux-kernel,
nikolaus.voss, andriy.shevchenko, garsilva, keescook,
linux-usb-owner
On 08/05/2020 15:22, Angus Ainslie wrote:
> Hi,
>
> On 2020-05-08 07:01, Heikki Krogerus wrote:
>> Hi,
>>
>> On Thu, May 07, 2020 at 10:47:31PM +0100, Bryan O'Donoghue wrote:
>>> V2:
>>> - Put myself down as sole schema maintainer as suggested - Andy
>>> - Fixed whitespace typo - Andy
>>> - Removed ifdef and of_match_ptr() - Andy
>>>
>>> V1:
>>> This simple series adds DT binding yaml and a DT lookup table for the
>>> tps6598x.
>>>
>>> Its possible to use i2c id_table to match the 'compatible =
>>> "ti,tps6598x"
>>> and probe that way, however I think it is worthwhile adding a
>>> specific OF
>>> way of doing it and having an accompanying yaml as an example.
>>>
>>> Bryan O'Donoghue (2):
>>> dt-bindings: usb: Add TI tps6598x device tree binding documentation
>>> usb: typec: tps6598x: Add OF probe binding
>>>
>>> .../devicetree/bindings/usb/ti,tps6598x.yaml | 64 +++++++++++++++++++
>>> drivers/usb/typec/tps6598x.c | 7 ++
>>> 2 files changed, 71 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>>
>> There was already a series from Angus [1] for this. The bindings
>> looked a bit different, but I think we should use these, because in
>> the DT bindings from Angus there appeared to be definitions for OF
>> graph that was not used. Or maybe I got it wrong?
>>
>
> I was trying to include optional components but was not sure of the
> syntax so that might have been wrong.
>
>> Angus, is it OK if we use these patches instead the ones from you?
>>
>
> Yeah these ones will work great for what we need.
>
> Sorry Bryan I didn't realize there was a patch already in progress.
>
> @Bryan, I'm going to send up some extcon patches for the tps6598x soon
> but maybe I should check and make sure you don't already have anything
> planned there.
>
> It still needs to be retested after cleaning up but it's the top 9
> patches here:
>
> https://source.puri.sm/angus.ainslie/linux-next/-/commits/next/extcon
Makes me glad I didn't try to touch the PDO stuff :)
That series looks fine to me.
The only other modification I have is here.
https://lore.kernel.org/linux-usb/20200507215938.1983363-2-bryan.odonoghue@linaro.org/T/#u
which is about data-role switching.
---
bod
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/2] Add TI tps6598x DT binding and probe
2020-05-08 14:47 ` Bryan O'Donoghue
@ 2020-05-08 16:21 ` Angus Ainslie
0 siblings, 0 replies; 10+ messages in thread
From: Angus Ainslie @ 2020-05-08 16:21 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: Heikki Krogerus, robh+dt, linux-usb, devicetree, gregkh,
linux-kernel, nikolaus.voss, andriy.shevchenko, garsilva,
keescook, linux-usb-owner
On 2020-05-08 07:47, Bryan O'Donoghue wrote:
> On 08/05/2020 15:22, Angus Ainslie wrote:
>> Hi,
>>
>> On 2020-05-08 07:01, Heikki Krogerus wrote:
>>
>>> Angus, is it OK if we use these patches instead the ones from you?
>>>
>>
>> Yeah these ones will work great for what we need.
>>
>> Sorry Bryan I didn't realize there was a patch already in progress.
>>
>> @Bryan, I'm going to send up some extcon patches for the tps6598x soon
>> but maybe I should check and make sure you don't already have anything
>> planned there.
>>
>> It still needs to be retested after cleaning up but it's the top 9
>> patches here:
>>
>> https://source.puri.sm/angus.ainslie/linux-next/-/commits/next/extcon
>
> Makes me glad I didn't try to touch the PDO stuff :)
>
> That series looks fine to me.
>
> The only other modification I have is here.
>
> https://lore.kernel.org/linux-usb/20200507215938.1983363-2-bryan.odonoghue@linaro.org/T/#u
>
> which is about data-role switching.
We have something similar but that one should work for us. I'll try and
test that early next week.
Thanks
Angus
>
> ---
> bod
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding
2020-05-07 21:47 ` [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding Bryan O'Donoghue
@ 2020-05-09 7:59 ` Martin Kepplinger
2020-05-11 10:29 ` Heikki Krogerus
1 sibling, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2020-05-09 7:59 UTC (permalink / raw)
To: bryan.odonoghue
Cc: andriy.shevchenko, devicetree, garsilva, gregkh, heikki.krogerus,
keescook, linux-kernel, linux-usb, nikolaus.voss, robh,
Martin Kepplinger
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Adds a MODULE_DEVICE_TABLE() to allow probing of this driver from a DTS
> setting.
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
thanks!
martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding
2020-05-07 21:47 ` [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding Bryan O'Donoghue
2020-05-09 7:59 ` Martin Kepplinger
@ 2020-05-11 10:29 ` Heikki Krogerus
1 sibling, 0 replies; 10+ messages in thread
From: Heikki Krogerus @ 2020-05-11 10:29 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: robh+dt, linux-usb, devicetree, gregkh, linux-kernel,
nikolaus.voss, andriy.shevchenko, garsilva, keescook
On Thu, May 07, 2020 at 10:47:33PM +0100, Bryan O'Donoghue wrote:
> Adds a MODULE_DEVICE_TABLE() to allow probing of this driver from a DTS
> setting.
>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tps6598x.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
> index 0698addd1185..defa651282b0 100644
> --- a/drivers/usb/typec/tps6598x.c
> +++ b/drivers/usb/typec/tps6598x.c
> @@ -563,6 +563,12 @@ static int tps6598x_remove(struct i2c_client *client)
> return 0;
> }
>
> +static const struct of_device_id tps6598x_of_match[] = {
> + { .compatible = "ti,tps6598x", },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, tps6598x_of_match);
> +
> static const struct i2c_device_id tps6598x_id[] = {
> { "tps6598x" },
> { }
> @@ -572,6 +578,7 @@ MODULE_DEVICE_TABLE(i2c, tps6598x_id);
> static struct i2c_driver tps6598x_i2c_driver = {
> .driver = {
> .name = "tps6598x",
> + .of_match_table = tps6598x_of_match,
> },
> .probe_new = tps6598x_probe,
> .remove = tps6598x_remove,
> --
> 2.25.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation
2020-05-07 21:47 ` [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation Bryan O'Donoghue
@ 2020-05-15 3:09 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-05-15 3:09 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: heikki.krogerus, linux-usb, devicetree, gregkh, linux-kernel,
nikolaus.voss, andriy.shevchenko, garsilva, keescook
On Thu, May 07, 2020 at 10:47:32PM +0100, Bryan O'Donoghue wrote:
> Add device tree binding documentation for the Texas Instruments tps6598x
> Type-C chip driver.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/usb/ti,tps6598x.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> new file mode 100644
> index 000000000000..8eaf4b6c4735
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/ti,tps6598x.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Texas Instruments 6598x Type-C Port Switch and Power Delivery controller DT bindings
> +
> +maintainers:
> + - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> +
> +description: |
> + Texas Instruments 6598x Type-C Port Switch and Power Delivery controller
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tps6598x
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-names:
> + items:
> + - const: irq
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + tps6598x: tps6598x@38 {
> + compatible = "ti,tps6598x";
> + reg = <0x38>;
> +
> + interrupt-parent = <&msmgpio>;
> + interrupts = <107 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "irq";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&typec_pins>;
> +
> + typec_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + port {
The connector binding has specific numbering of the ports defined for
HS, SS, alt mode.
So you should have 'ports' here.
> + typec_ep: endpoint {
> + remote-endpoint = <&otg_ep>;
> + };
> + };
> + };
> + };
> + };
> +...
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-05-15 3:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 21:47 [PATCH v2 0/2] Add TI tps6598x DT binding and probe Bryan O'Donoghue
2020-05-07 21:47 ` [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation Bryan O'Donoghue
2020-05-15 3:09 ` Rob Herring
2020-05-07 21:47 ` [PATCH v2 2/2] usb: typec: tps6598x: Add OF probe binding Bryan O'Donoghue
2020-05-09 7:59 ` Martin Kepplinger
2020-05-11 10:29 ` Heikki Krogerus
2020-05-08 14:01 ` [PATCH v2 0/2] Add TI tps6598x DT binding and probe Heikki Krogerus
2020-05-08 14:22 ` Angus Ainslie
2020-05-08 14:47 ` Bryan O'Donoghue
2020-05-08 16:21 ` Angus Ainslie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).