From: Alan Stern <stern@rowland.harvard.edu>
To: Bin Liu <b-liu@ti.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: musb: return -ESHUTDOWN in urb when three-strikes error happened
Date: Thu, 14 May 2020 14:55:49 -0400 [thread overview]
Message-ID: <20200514185549.GA22428@rowland.harvard.edu> (raw)
In-Reply-To: <20200514170023.GD11463@iaqt7>
On Thu, May 14, 2020 at 12:00:23PM -0500, Bin Liu wrote:
> > Still, it's worth pointing out that this change abuses the API (perhaps
> > mentioning it in a comment). And it still would be preferable to fix
>
> Okay, I will add those notes in comment in v2.
>
> > the drivers in question, impractical though that may be. (I have a hard
> > time believing there are really 500 of them getting this wrong...)
>
> I am not sure about it either, but yeah it is not practical to fix the
> issue in device drivers. So far I have seen 3 reports of this issue:
>
> 1. with FTDI usb-serial adapter, the issue is in the usb serial generic
> driver;
It shouldn't be hard to fix this. We don't even need a delayed retry;
the driver can simply treat -EPROTO as an unrecoverable error, just like
-ESHUTDOWN.
Alan Stern
> 2. with a modem, the issue is in usb wwan driver as I fixed in the patch
> I sent yesterday;
>
> 2. another modem, before I was able to locate the offending device
> driver, the guy who reported the issue disappeared, and not responding
> me.
>
> -Bin.
next prev parent reply other threads:[~2020-05-14 19:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 21:36 [PATCH] usb: musb: return -ESHUTDOWN in urb when three-strikes error happened Bin Liu
2020-05-14 1:32 ` Alan Stern
2020-05-14 14:28 ` Bin Liu
2020-05-14 14:40 ` Alan Stern
2020-05-14 15:02 ` Bin Liu
2020-05-14 15:37 ` Bin Liu
2020-05-14 16:26 ` Alan Stern
2020-05-14 17:00 ` Bin Liu
2020-05-14 18:55 ` Alan Stern [this message]
2020-05-19 17:12 ` Bin Liu
2020-05-19 20:01 ` Alan Stern
2020-05-20 14:31 ` Bin Liu
2020-05-20 16:40 ` Alan Stern
2020-05-20 18:05 ` Bin Liu
2020-05-20 18:25 ` Alan Stern
2020-05-20 18:59 ` Bin Liu
2020-05-19 17:28 ` [PATCH v2] " Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514185549.GA22428@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=b-liu@ti.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).