From: Bin Liu <b-liu@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: return -ESHUTDOWN in urb when three-strikes error happened
Date: Wed, 20 May 2020 13:05:50 -0500 [thread overview]
Message-ID: <20200520180550.GD15845@iaqt7> (raw)
In-Reply-To: <20200520164055.GB11084@rowland.harvard.edu>
On Wed, May 20, 2020 at 12:40:55PM -0400, Alan Stern wrote:
> > > Then do you think we should change the API?
> > >
> > > Right now it's a little too complicated. There's no real reason for
> > > EPROTO, EILSEQ, and ETIME to be different codes. And now you seem to be
> > > suggesting that we should fold them all into ESHUTDOWN.
> >
> > I haven't studied all the USB error code enough to suggest this. I am
> > only changing to ESHUTDOWN in musb driver because I know this 3-strikes
> > error should only be caused by USB device disabled, which is the
> > definition of ESHUTDOWN in error-code.rst.
>
> You should spend a little time studying the error-codes document.
> EPROTO, EILSEQ, and ETIME describe different kinds of errors that all
> fall into the 3-strikes category.
But not all device drivers, except the 3 I found, treat EPROTO as fatal,
and I cannot fix it in all the device drivers. The only thing I can do
at this moment is changing the MUSB HCD driver to return ESHUTDOWN which
still follows the document, kind of.
-Bin.
next prev parent reply other threads:[~2020-05-20 18:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 21:36 [PATCH] usb: musb: return -ESHUTDOWN in urb when three-strikes error happened Bin Liu
2020-05-14 1:32 ` Alan Stern
2020-05-14 14:28 ` Bin Liu
2020-05-14 14:40 ` Alan Stern
2020-05-14 15:02 ` Bin Liu
2020-05-14 15:37 ` Bin Liu
2020-05-14 16:26 ` Alan Stern
2020-05-14 17:00 ` Bin Liu
2020-05-14 18:55 ` Alan Stern
2020-05-19 17:12 ` Bin Liu
2020-05-19 20:01 ` Alan Stern
2020-05-20 14:31 ` Bin Liu
2020-05-20 16:40 ` Alan Stern
2020-05-20 18:05 ` Bin Liu [this message]
2020-05-20 18:25 ` Alan Stern
2020-05-20 18:59 ` Bin Liu
2020-05-19 17:28 ` [PATCH v2] " Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520180550.GD15845@iaqt7 \
--to=b-liu@ti.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).