From: Johan Hovold <johan@kernel.org>
To: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
Cc: "Johan Hovold" <johan@kernel.org>,
linux-kernel@vger.kernel.org, "Bjørn Mork" <bjorn@mork.no>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
Date: Mon, 5 Oct 2020 13:06:38 +0200 [thread overview]
Message-ID: <20201005110638.GP5141@localhost> (raw)
In-Reply-To: <20201005130134.459b4de9@monster.powergraphx.local>
On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote:
> On Mon, 5 Oct 2020 10:20:45 +0200
> Johan Hovold <johan@kernel.org> wrote:
>
> > On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
> > > Add usb ids of the Cellient MPL200 card.
> > >
> > > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > > ---
> > > @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
> > > { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff,
> > > 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2,
> > > 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
> > > + { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
> > > + .driver_info = RSVD(1) | RSVD(4) },
> >
> > Would you mind posting the output of "lsusb -v" for this device?
>
> I would like to, but unfortunately I lost access to this really rare hardware
> about a month ago. It is a Qualcomm device (0x05c6:0x9025) with a slightly
> modified firmware to rebrand it as a Cellient product with a different vendor
> id. How to proceed here, if I have no access to it anymore? Drop it?
No, that's ok, I've applied the patch now. It's just that in case we
ever need to revisit the handling of quirky devices, it has proven
useful to have a record the descriptors.
Do you remember the interface layout and why you blacklisted interface
1?
Johan
next prev parent reply other threads:[~2020-10-05 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 9:39 [PATCH 0/2] add Cellient MPL200 card Wilken Gottwalt
2020-10-03 9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
2020-10-04 15:29 ` Bjørn Mork
2020-10-04 18:30 ` Wilken Gottwalt
2020-10-05 8:06 ` Johan Hovold
2020-10-05 8:19 ` Johan Hovold
2020-10-05 10:07 ` Bjørn Mork
2020-10-03 9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
2020-10-05 8:20 ` Johan Hovold
2020-10-05 11:01 ` Wilken Gottwalt
2020-10-05 11:06 ` Johan Hovold [this message]
2020-10-05 11:36 ` Lars Melin
2020-10-05 12:07 ` Wilken Gottwalt
2020-10-06 7:02 ` Johan Hovold
2020-10-08 6:47 ` Wilken Gottwalt
2020-10-08 7:16 ` Johan Hovold
2020-10-05 12:02 ` Wilken Gottwalt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005110638.GP5141@localhost \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wilken.gottwalt@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).