linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Lars Melin" <larsm17@gmail.com>,
	linux-kernel@vger.kernel.org, "Bjørn Mork" <bjorn@mork.no>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
Date: Thu, 8 Oct 2020 08:47:33 +0200	[thread overview]
Message-ID: <20201008084733.41ba3cec@monster.powergraphx.local> (raw)
In-Reply-To: <20201006070201.GB26280@localhost>

On Tue, 6 Oct 2020 09:02:01 +0200
Johan Hovold <johan@kernel.org> wrote:

> On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote:
> > On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin <larsm17@gmail.com> wrote:
> > > On 10/5/2020 18:06, Johan Hovold wrote:
> 
> > > > Do you remember the interface layout and why you blacklisted interface
> > > > 1?
> 
> > > It is very likely that Cellient has replaced the VID with their own and 
> > > kept the PID, it is something other mfgrs has done when buying modules 
> > > from Qualcomm's series of devices with predefined composition.
> > > 
> > > The MS Windows driver for 05c6:9025 describes the interfaces as:
> > > 
> > > MI_00 Qualcomm HS-USB Diagnostics 9025
> > > MI_01 Android Composite ADB Interface
> > > MI_02 Qualcomm HS-USB Android Modem 9025
> > > MI_03 Qualcomm HS-USB NMEA 9025
> > > MI_04 Qualcomm Wireless HS-USB Ethernet Adapter 9025
> > > MI_05 USB Mass Storage Device
> > > 
> > > where the net interface is for QMI/RMNET.
> > > It fully matches the blacklisting Wilken has done for 2692:9025
> > 
> > Does your device have a GPS connector? Mine had not and I'm not sure
> > if the description of MI_01 is actually correct. I remember looking at
> > this port and seeing bogus NMEA data.
> 
> Well if it's NMEA then the interface shouldn't be blacklisted (even if
> the values are bogus on your device), but if it's ADB it should be as
> that is handled by userspace.
> 
> Here's some lsusb output from a Cellient MPL200 that still uses the
> Qualcomm VID:
> 
> 	https://www.mail-archive.com/modemmanager-devel@lists.freedesktop.org/msg04523.html
> 
> which gives some support to Lars's hypothesis. I guess we'll just keep
> the first interface reserved.

Lars and Johan are right here. I found an older external Gobi driver
where I actually added comments saying interface 1 is ADB and interface 3
is NMEA delivering only zeroed values because of the missing antenna
connector, at least for the models I had access to.

Will

  reply	other threads:[~2020-10-08  6:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-03  9:39 [PATCH 0/2] add Cellient MPL200 card Wilken Gottwalt
2020-10-03  9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
2020-10-04 15:29   ` Bjørn Mork
2020-10-04 18:30     ` Wilken Gottwalt
2020-10-05  8:06       ` Johan Hovold
2020-10-05  8:19         ` Johan Hovold
2020-10-05 10:07       ` Bjørn Mork
2020-10-03  9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
2020-10-05  8:20   ` Johan Hovold
2020-10-05 11:01     ` Wilken Gottwalt
2020-10-05 11:06       ` Johan Hovold
2020-10-05 11:36         ` Lars Melin
2020-10-05 12:07           ` Wilken Gottwalt
2020-10-06  7:02             ` Johan Hovold
2020-10-08  6:47               ` Wilken Gottwalt [this message]
2020-10-08  7:16                 ` Johan Hovold
2020-10-05 12:02         ` Wilken Gottwalt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008084733.41ba3cec@monster.powergraphx.local \
    --to=wilken.gottwalt@mailbox.org \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=kuba@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).