* [PATCH v3 01/11] dt-bindings: usb: generic-ohci: Document dr_mode property
[not found] <20210630073013.22415-1-biju.das.jz@bp.renesas.com>
@ 2021-06-30 7:30 ` Biju Das
2021-07-14 21:16 ` Rob Herring
2021-06-30 7:30 ` [PATCH v3 02/11] dt-bindings: usb: generic-ehci: " Biju Das
2021-06-30 7:30 ` [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das
2 siblings, 1 reply; 7+ messages in thread
From: Biju Das @ 2021-06-30 7:30 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Greg Kroah-Hartman, linux-usb, devicetree,
Geert Uytterhoeven, Yoshihiro Shimoda, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Document the optional property dr_mode present on both RZ/G2 and
R-Car Gen3 SoCs.
It fixes the dtbs_check warning,
'dr_mode' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v2->v3:
* Dropped RZ/G2L SoC and USBPHY control IP is modelled as reset binding.
v2:
* New patch
---
Documentation/devicetree/bindings/usb/generic-ohci.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index 0f5f6ea702d0..569777a76c90 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -109,6 +109,11 @@ properties:
iommus:
maxItems: 1
+ dr_mode:
+ enum:
+ - host
+ - otg
+
required:
- compatible
- reg
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 02/11] dt-bindings: usb: generic-ehci: Document dr_mode property
[not found] <20210630073013.22415-1-biju.das.jz@bp.renesas.com>
2021-06-30 7:30 ` [PATCH v3 01/11] dt-bindings: usb: generic-ohci: Document dr_mode property Biju Das
@ 2021-06-30 7:30 ` Biju Das
2021-07-14 21:16 ` Rob Herring
2021-06-30 7:30 ` [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das
2 siblings, 1 reply; 7+ messages in thread
From: Biju Das @ 2021-06-30 7:30 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Greg Kroah-Hartman, linux-usb, devicetree,
Geert Uytterhoeven, Yoshihiro Shimoda, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Document the optional property dr_mode present on both RZ/G2 and
R-Car Gen3 SoCs.
It fixes dtbs_check warning,
'dr_mode' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v2->v3:
* Dropped RZ/G2L SoC and USBPHY control IP is modelled as reset binding.
v2:
* New patch
---
Documentation/devicetree/bindings/usb/generic-ehci.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index 8089dc956ba3..f6e5e4abb85b 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -142,6 +142,11 @@ properties:
iommus:
maxItems: 1
+ dr_mode:
+ enum:
+ - host
+ - otg
+
required:
- compatible
- reg
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings
[not found] <20210630073013.22415-1-biju.das.jz@bp.renesas.com>
2021-06-30 7:30 ` [PATCH v3 01/11] dt-bindings: usb: generic-ohci: Document dr_mode property Biju Das
2021-06-30 7:30 ` [PATCH v3 02/11] dt-bindings: usb: generic-ehci: " Biju Das
@ 2021-06-30 7:30 ` Biju Das
2021-07-14 21:24 ` Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Biju Das @ 2021-06-30 7:30 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb,
devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Document RZ/G2L (R9A07G044L) SoC bindings.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v3:
* Updated the bindings as per the USBPHY control IP.
---
.../bindings/usb/renesas,usbhs.yaml | 21 +++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
index ad73339ffe1d..5562839bef8d 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
@@ -17,7 +17,9 @@ properties:
- const: renesas,rza1-usbhs
- items:
- - const: renesas,usbhs-r7s9210 # RZ/A2
+ - enum:
+ - renesas,usbhs-r7s9210 # RZ/A2
+ - renesas,usbhs-r9a07g044 # RZ/G2{L,LC}
- const: renesas,rza2-usbhs
- items:
@@ -59,7 +61,7 @@ properties:
- description: USB 2.0 clock selector
interrupts:
- maxItems: 1
+ minItems: 1
renesas,buswait:
$ref: /schemas/types.yaml#/definitions/uint32
@@ -108,6 +110,21 @@ required:
- clocks
- interrupts
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: renesas,usbhs-r9a07g044
+ then:
+ properties:
+ interrupts:
+ items:
+ - description: U2P_IXL_INT
+ - description: U2P_INT_DMA[0]
+ - description: U2P_INT_DMA[1]
+ - description: U2P_INT_DMAERR
+
additionalProperties: false
examples:
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 01/11] dt-bindings: usb: generic-ohci: Document dr_mode property
2021-06-30 7:30 ` [PATCH v3 01/11] dt-bindings: usb: generic-ohci: Document dr_mode property Biju Das
@ 2021-07-14 21:16 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-07-14 21:16 UTC (permalink / raw)
To: Biju Das
Cc: Geert Uytterhoeven, devicetree, Rob Herring, Yoshihiro Shimoda,
linux-renesas-soc, linux-usb, Chris Paterson, Greg Kroah-Hartman,
Biju Das, Prabhakar Mahadev Lad
On Wed, 30 Jun 2021 08:30:03 +0100, Biju Das wrote:
> Document the optional property dr_mode present on both RZ/G2 and
> R-Car Gen3 SoCs.
>
> It fixes the dtbs_check warning,
> 'dr_mode' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v2->v3:
> * Dropped RZ/G2L SoC and USBPHY control IP is modelled as reset binding.
> v2:
> * New patch
> ---
> Documentation/devicetree/bindings/usb/generic-ohci.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 02/11] dt-bindings: usb: generic-ehci: Document dr_mode property
2021-06-30 7:30 ` [PATCH v3 02/11] dt-bindings: usb: generic-ehci: " Biju Das
@ 2021-07-14 21:16 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-07-14 21:16 UTC (permalink / raw)
To: Biju Das
Cc: Prabhakar Mahadev Lad, linux-renesas-soc, Yoshihiro Shimoda,
Greg Kroah-Hartman, Geert Uytterhoeven, Chris Paterson,
devicetree, linux-usb, Rob Herring, Biju Das
On Wed, 30 Jun 2021 08:30:04 +0100, Biju Das wrote:
> Document the optional property dr_mode present on both RZ/G2 and
> R-Car Gen3 SoCs.
>
> It fixes dtbs_check warning,
> 'dr_mode' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v2->v3:
> * Dropped RZ/G2L SoC and USBPHY control IP is modelled as reset binding.
> v2:
> * New patch
> ---
> Documentation/devicetree/bindings/usb/generic-ehci.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings
2021-06-30 7:30 ` [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das
@ 2021-07-14 21:24 ` Rob Herring
2021-07-15 7:18 ` Biju Das
0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2021-07-14 21:24 UTC (permalink / raw)
To: Biju Das
Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
On Wed, Jun 30, 2021 at 08:30:11AM +0100, Biju Das wrote:
> Document RZ/G2L (R9A07G044L) SoC bindings.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v3:
> * Updated the bindings as per the USBPHY control IP.
> ---
> .../bindings/usb/renesas,usbhs.yaml | 21 +++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index ad73339ffe1d..5562839bef8d 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -17,7 +17,9 @@ properties:
> - const: renesas,rza1-usbhs
>
> - items:
> - - const: renesas,usbhs-r7s9210 # RZ/A2
> + - enum:
> + - renesas,usbhs-r7s9210 # RZ/A2
> + - renesas,usbhs-r9a07g044 # RZ/G2{L,LC}
> - const: renesas,rza2-usbhs
>
> - items:
> @@ -59,7 +61,7 @@ properties:
> - description: USB 2.0 clock selector
>
> interrupts:
> - maxItems: 1
> + minItems: 1
maxItems: 4
>
> renesas,buswait:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -108,6 +110,21 @@ required:
> - clocks
> - interrupts
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,usbhs-r9a07g044
> + then:
> + properties:
> + interrupts:
> + items:
> + - description: U2P_IXL_INT
> + - description: U2P_INT_DMA[0]
> + - description: U2P_INT_DMA[1]
> + - description: U2P_INT_DMAERR
If the first interrupt is the same on all devices, then this items
list should be moved to the top level and just have a 'minItems: 4'
here.
else:
properties:
interrupts:
maxItems: 1
> +
> additionalProperties: false
>
> examples:
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings
2021-07-14 21:24 ` Rob Herring
@ 2021-07-15 7:18 ` Biju Das
0 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2021-07-15 7:18 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document
> RZ/G2L bindings
>
> On Wed, Jun 30, 2021 at 08:30:11AM +0100, Biju Das wrote:
> > Document RZ/G2L (R9A07G044L) SoC bindings.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v3:
> > * Updated the bindings as per the USBPHY control IP.
> > ---
> > .../bindings/usb/renesas,usbhs.yaml | 21 +++++++++++++++++--
> > 1 file changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > index ad73339ffe1d..5562839bef8d 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > @@ -17,7 +17,9 @@ properties:
> > - const: renesas,rza1-usbhs
> >
> > - items:
> > - - const: renesas,usbhs-r7s9210 # RZ/A2
> > + - enum:
> > + - renesas,usbhs-r7s9210 # RZ/A2
> > + - renesas,usbhs-r9a07g044 # RZ/G2{L,LC}
> > - const: renesas,rza2-usbhs
> >
> > - items:
> > @@ -59,7 +61,7 @@ properties:
> > - description: USB 2.0 clock selector
> >
> > interrupts:
> > - maxItems: 1
> > + minItems: 1
>
> maxItems: 4
OK.
>
> >
> > renesas,buswait:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > @@ -108,6 +110,21 @@ required:
> > - clocks
> > - interrupts
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,usbhs-r9a07g044
> > + then:
> > + properties:
> > + interrupts:
> > + items:
> > + - description: U2P_IXL_INT
> > + - description: U2P_INT_DMA[0]
> > + - description: U2P_INT_DMA[1]
> > + - description: U2P_INT_DMAERR
>
> If the first interrupt is the same on all devices, then this items list
> should be moved to the top level and just have a 'minItems: 4'
> here.
From the hardware point, it is same "HSUSB interrupt"
But HW manual is representing it differently
R-Car Gen2, RZ/G1:-USB2.0_597 (OTG)
R-Car Gen3, RZ/G2:- EHCI/OHCI OTG.ch0
RZ/G2L: U2P_IXL_INT
Other devices ??.
So it make sense to leave as it is. Please let me know if you think other wise.
Regards,
Biju
>
>
> else:
> properties:
> interrupts:
> maxItems: 1
>
>
> > +
> > additionalProperties: false
> >
> > examples:
> > --
> > 2.17.1
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-15 7:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210630073013.22415-1-biju.das.jz@bp.renesas.com>
2021-06-30 7:30 ` [PATCH v3 01/11] dt-bindings: usb: generic-ohci: Document dr_mode property Biju Das
2021-07-14 21:16 ` Rob Herring
2021-06-30 7:30 ` [PATCH v3 02/11] dt-bindings: usb: generic-ehci: " Biju Das
2021-07-14 21:16 ` Rob Herring
2021-06-30 7:30 ` [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das
2021-07-14 21:24 ` Rob Herring
2021-07-15 7:18 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).