linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bug report] usb: isp1760: add support for isp1763
@ 2021-07-26  7:28 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2021-07-26  7:28 UTC (permalink / raw)
  To: rui.silva; +Cc: linux-usb

Hello Rui Miguel Silva,

The patch 60d789f3bfbb: "usb: isp1760: add support for isp1763" from
May 13, 2021, leads to the following static checker warning:

	drivers/usb/isp1760/isp1760-hcd.c:276 isp1760_hcd_clear_and_wait()
	warn: sleeping in atomic context

drivers/usb/isp1760/isp1760-hcd.c
    268 static int isp1760_hcd_clear_and_wait(struct usb_hcd *hcd, u32 field,
    269 				      u32 timeout_us)
    270 {
    271 	struct isp1760_hcd *priv = hcd_to_priv(hcd);
    272 	u32 val;
    273 
    274 	isp1760_hcd_clear(hcd, field);
    275 
--> 276 	return regmap_field_read_poll_timeout(priv->fields[field], val,
    277 					      !val, 10, timeout_us);
                                                            ^^
Originally this used to call read_poll_timeout() with 0 us_timeout (no
sleeping).  The caller always holds a spin_lock.

    278 }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-26  7:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26  7:28 [bug report] usb: isp1760: add support for isp1763 Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).