From: Pete Zaitcev <zaitcev@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Juergen Stuber <starblue@users.sourceforge.net>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] USB: make devnode() callback in usb_class_driver take a const *
Date: Tue, 11 Oct 2022 00:45:50 -0500 [thread overview]
Message-ID: <20221011004550.46e068f5@niphredil.zaitcev.lan> (raw)
In-Reply-To: <20221001165128.2688526-1-gregkh@linuxfoundation.org>
On Sat, 1 Oct 2022 18:51:28 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> +++ b/drivers/usb/class/usblp.c
> @@ -1090,7 +1090,7 @@ static const struct file_operations usblp_fops = {
> -static char *usblp_devnode(struct device *dev, umode_t *mode)
> +static char *usblp_devnode(const struct device *dev, umode_t *mode)
> {
> return kasprintf(GFP_KERNEL, "usb/%s", dev_name(dev));
> }
Seems obvious.
Acked-by: Pete Zaitcev <zaitcev@redhat.com>
-- P
prev parent reply other threads:[~2022-10-11 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 16:51 [PATCH] USB: make devnode() callback in usb_class_driver take a const * Greg Kroah-Hartman
2022-10-03 6:39 ` Johan Hovold
2022-10-04 8:24 ` Jiri Kosina
2022-10-11 5:45 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011004550.46e068f5@niphredil.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=starblue@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).