* [PATCH] usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode
@ 2020-11-11 13:12 Chris Brandt
2020-11-12 11:41 ` Oliver Neukum
0 siblings, 1 reply; 2+ messages in thread
From: Chris Brandt @ 2020-11-11 13:12 UTC (permalink / raw)
To: Oliver Neukum, Greg Kroah-Hartman
Cc: linux-usb, linux-renesas-soc, Jesse Pfeister, Chris Brandt, stable
Renesas R-Car and RZ/G SoCs have a firmware download mode over USB.
However, on reset a banner string is transmitted out which is not expected
to be echoed back and will corrupt the protocol.
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Cc: stable <stable@vger.kernel.org>
---
drivers/usb/class/cdc-acm.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 1e7568867910..f52f1bc0559f 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1693,6 +1693,15 @@ static const struct usb_device_id acm_ids[] = {
{ USB_DEVICE(0x0870, 0x0001), /* Metricom GS Modem */
.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
},
+ { USB_DEVICE(0x045b, 0x023c), /* Renesas USB Download mode */
+ .driver_info = DISABLE_ECHO, /* Don't echo banner */
+ },
+ { USB_DEVICE(0x045b, 0x0248), /* Renesas USB Download mode */
+ .driver_info = DISABLE_ECHO, /* Don't echo banner */
+ },
+ { USB_DEVICE(0x045b, 0x024D), /* Renesas USB Download mode */
+ .driver_info = DISABLE_ECHO, /* Don't echo banner */
+ },
{ USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */
.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
},
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode
2020-11-11 13:12 [PATCH] usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode Chris Brandt
@ 2020-11-12 11:41 ` Oliver Neukum
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Neukum @ 2020-11-12 11:41 UTC (permalink / raw)
To: Chris Brandt, Greg Kroah-Hartman
Cc: linux-usb, linux-renesas-soc, Jesse Pfeister, stable
Am Mittwoch, den 11.11.2020, 08:12 -0500 schrieb Chris Brandt:
> Renesas R-Car and RZ/G SoCs have a firmware download mode over USB.
> However, on reset a banner string is transmitted out which is not expected
> to be echoed back and will corrupt the protocol.
>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> Cc: stable <stable@vger.kernel.org>
Acked-by: Oliver Neukum <oneukum@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 13:12 [PATCH] usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode Chris Brandt
2020-11-12 11:41 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).