From: Thierry Reding <thierry.reding@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
Jonathan Corbet <corbet@lwn.net>,
od@zcrc.me, Mathieu Malaterre <malat@debian.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-mips@linux-mips.org, linux-doc@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v7 12/24] pwm: jz4740: Use regmap and clocks from TCU driver
Date: Fri, 12 Oct 2018 12:39:57 +0200 [thread overview]
Message-ID: <20181012103957.GF9162@ulmo> (raw)
In-Reply-To: <20180821171635.22740-13-paul@crapouillou.net>
[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]
On Tue, Aug 21, 2018 at 07:16:23PM +0200, Paul Cercueil wrote:
> The ingenic-timer "TCU" driver provides us with a regmap, that we can
> use to safely access the TCU registers.
>
> It also provides us with clocks, that can be (un)gated, reparented or
> reclocked from devicetree, instead of having these settings hardcoded in
> this driver.
>
> While this driver is devicetree-compatible, it is never (as of now)
> probed from devicetree, so this change does not introduce a ABI problem
> with current devicetree files.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v5: New patch
>
> v6: Drop requirement of probing from devicetree
>
> v7: No change
>
> drivers/pwm/Kconfig | 2 +
> drivers/pwm/pwm-jz4740.c | 124 +++++++++++++++++++++++++++++++----------------
> 2 files changed, 83 insertions(+), 43 deletions(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index a4d262db9945..58359bf22b96 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -202,6 +202,8 @@ config PWM_IMX
> config PWM_JZ4740
> tristate "Ingenic JZ47xx PWM support"
> depends on MACH_INGENIC
> + depends on COMMON_CLK
> + select INGENIC_TIMER
> help
> Generic PWM framework driver for Ingenic JZ47xx based
> machines.
> diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm/pwm-jz4740.c
> index a7b134af5e04..1bda8d8e9865 100644
> --- a/drivers/pwm/pwm-jz4740.c
> +++ b/drivers/pwm/pwm-jz4740.c
> @@ -14,21 +14,21 @@
> */
>
> #include <linux/clk.h>
> +#include <linux/clk-provider.h>
Why do you need this?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-12 18:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 17:16 [PATCH v7 00/24] TCU patchset v7 Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 01/24] mfd: Add ingenic-tcu.h header Paul Cercueil
2018-09-10 14:58 ` Lee Jones
2018-08-21 17:16 ` [PATCH v7 02/24] dt-bindings: ingenic: Add DT bindings for TCU clocks Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 03/24] doc: Add doc for the Ingenic TCU hardware Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 04/24] dt-bindings: Add doc for the Ingenic TCU drivers Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 05/24] clocksource: Add a new timer-ingenic driver Paul Cercueil
2018-08-28 17:23 ` Paul Burton
2018-08-29 9:10 ` Daniel Lezcano
2018-08-29 17:43 ` Paul Burton
2018-09-24 3:12 ` Daniel Lezcano
2018-08-21 17:16 ` [PATCH v7 06/24] clocksource: Add driver for the Ingenic JZ47xx OST Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 07/24] MAINTAINERS: Add myself as maintainer for Ingenic TCU drivers Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 08/24] watchdog: jz4740: Use WDT clock provided by TCU driver Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 09/24] watchdog: jz4740: Use regmap " Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 10/24] watchdog: jz4740: Avoid starting watchdog in set_timeout Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 11/24] watchdog: jz4740: Drop dependency on MACH_JZ47xx, use COMPILE_TEST Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 12/24] pwm: jz4740: Use regmap and clocks from TCU driver Paul Cercueil
2018-08-28 17:30 ` Paul Burton
2018-10-12 10:39 ` Thierry Reding [this message]
2018-08-21 17:16 ` [PATCH v7 13/24] pwm: jz4740: Allow selection of PWM channels 0 and 1 Paul Cercueil
2018-10-12 10:40 ` Thierry Reding
2018-10-12 10:43 ` Thierry Reding
2018-08-21 17:16 ` [PATCH v7 14/24] pwm: jz4740: Drop dependency on MACH_INGENIC, use COMPILE_TEST Paul Cercueil
2018-10-12 10:41 ` Thierry Reding
2018-10-12 10:44 ` Thierry Reding
2018-08-21 17:16 ` [PATCH v7 15/24] pwm: jz4740: Remove unused devicetree compatible strings Paul Cercueil
2018-10-12 10:42 ` Thierry Reding
2018-08-21 17:16 ` [PATCH v7 16/24] pwm: jz4740: Add support for the JZ4725B Paul Cercueil
2018-10-12 10:43 ` Thierry Reding
2018-08-21 17:16 ` [PATCH v7 17/24] clk: jz4740: Add TCU clock Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 18/24] MIPS: Kconfig: Select TCU timer driver when MACH_INGENIC is set Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 19/24] MIPS: jz4740: Add DTS nodes for the TCU drivers Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 20/24] MIPS: qi_lb60: Move PWM devices to devicetree Paul Cercueil
2018-08-21 17:18 ` [PATCH v7 21/24] MIPS: qi_lb60: Reduce system timer and clocksource to 750 kHz Paul Cercueil
2018-08-21 17:18 ` [PATCH v7 22/24] MIPS: CI20: Reduce system timer and clocksource to 3 MHz Paul Cercueil
2018-08-21 17:20 ` [PATCH v7 23/24] MIPS: CI20: defconfig: enable OST driver Paul Cercueil
2018-08-21 17:21 ` [PATCH v7 24/24] MIPS: jz4740: Drop obsolete code Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012103957.GF9162@ulmo \
--to=thierry.reding@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).