* [PATCH V2 0/1] watchdog: stm32_iwdg: don't print an error on probe deferral
@ 2020-11-06 14:23 Christophe Roullier
2020-11-06 14:23 ` [PATCH V2 1/1] " Christophe Roullier
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Roullier @ 2020-11-06 14:23 UTC (permalink / raw)
To: wim, linux, mcoquelin.stm32, alexandre.torgue
Cc: linux-watchdog, christophe.roullier, linux-kernel, linux-stm32,
linux-arm-kernel
Do not print an error trace when deferring probe for clock resources.
Version 2: Remark from Guenter and Ahmad
use dev_err_probe instead
Etienne Carriere (1):
watchdog: stm32_iwdg: don't print an error on probe deferral
drivers/watchdog/stm32_iwdg.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V2 1/1] watchdog: stm32_iwdg: don't print an error on probe deferral
2020-11-06 14:23 [PATCH V2 0/1] watchdog: stm32_iwdg: don't print an error on probe deferral Christophe Roullier
@ 2020-11-06 14:23 ` Christophe Roullier
2020-11-06 17:41 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Roullier @ 2020-11-06 14:23 UTC (permalink / raw)
To: wim, linux, mcoquelin.stm32, alexandre.torgue
Cc: linux-watchdog, christophe.roullier, linux-kernel, linux-stm32,
linux-arm-kernel, Etienne Carriere
From: Etienne Carriere <etienne.carriere@st.com>
Do not print an error trace when deferring probe for clock resources.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Christophe Roullier <christophe.roullier@st.com>
---
drivers/watchdog/stm32_iwdg.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
index 25188d6bbe15..a3436c296c97 100644
--- a/drivers/watchdog/stm32_iwdg.c
+++ b/drivers/watchdog/stm32_iwdg.c
@@ -162,18 +162,15 @@ static int stm32_iwdg_clk_init(struct platform_device *pdev,
u32 ret;
wdt->clk_lsi = devm_clk_get(dev, "lsi");
- if (IS_ERR(wdt->clk_lsi)) {
- dev_err(dev, "Unable to get lsi clock\n");
- return PTR_ERR(wdt->clk_lsi);
- }
+ if (IS_ERR(wdt->clk_lsi))
+ return dev_err_probe(dev, PTR_ERR(wdt->clk_lsi), "Unable to get lsi clock\n");
/* optional peripheral clock */
if (wdt->data->has_pclk) {
wdt->clk_pclk = devm_clk_get(dev, "pclk");
- if (IS_ERR(wdt->clk_pclk)) {
- dev_err(dev, "Unable to get pclk clock\n");
- return PTR_ERR(wdt->clk_pclk);
- }
+ if (IS_ERR(wdt->clk_pclk))
+ return dev_err_probe(dev, PTR_ERR(wdt->clk_pclk),
+ "Unable to get pclk clock\n");
ret = clk_prepare_enable(wdt->clk_pclk);
if (ret) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2 1/1] watchdog: stm32_iwdg: don't print an error on probe deferral
2020-11-06 14:23 ` [PATCH V2 1/1] " Christophe Roullier
@ 2020-11-06 17:41 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2020-11-06 17:41 UTC (permalink / raw)
To: Christophe Roullier
Cc: wim, mcoquelin.stm32, alexandre.torgue, linux-watchdog,
linux-kernel, linux-stm32, linux-arm-kernel, Etienne Carriere
On Fri, Nov 06, 2020 at 03:23:27PM +0100, Christophe Roullier wrote:
> From: Etienne Carriere <etienne.carriere@st.com>
>
> Do not print an error trace when deferring probe for clock resources.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
> Signed-off-by: Christophe Roullier <christophe.roullier@st.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/stm32_iwdg.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
> index 25188d6bbe15..a3436c296c97 100644
> --- a/drivers/watchdog/stm32_iwdg.c
> +++ b/drivers/watchdog/stm32_iwdg.c
> @@ -162,18 +162,15 @@ static int stm32_iwdg_clk_init(struct platform_device *pdev,
> u32 ret;
>
> wdt->clk_lsi = devm_clk_get(dev, "lsi");
> - if (IS_ERR(wdt->clk_lsi)) {
> - dev_err(dev, "Unable to get lsi clock\n");
> - return PTR_ERR(wdt->clk_lsi);
> - }
> + if (IS_ERR(wdt->clk_lsi))
> + return dev_err_probe(dev, PTR_ERR(wdt->clk_lsi), "Unable to get lsi clock\n");
>
> /* optional peripheral clock */
> if (wdt->data->has_pclk) {
> wdt->clk_pclk = devm_clk_get(dev, "pclk");
> - if (IS_ERR(wdt->clk_pclk)) {
> - dev_err(dev, "Unable to get pclk clock\n");
> - return PTR_ERR(wdt->clk_pclk);
> - }
> + if (IS_ERR(wdt->clk_pclk))
> + return dev_err_probe(dev, PTR_ERR(wdt->clk_pclk),
> + "Unable to get pclk clock\n");
>
> ret = clk_prepare_enable(wdt->clk_pclk);
> if (ret) {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-06 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 14:23 [PATCH V2 0/1] watchdog: stm32_iwdg: don't print an error on probe deferral Christophe Roullier
2020-11-06 14:23 ` [PATCH V2 1/1] " Christophe Roullier
2020-11-06 17:41 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).