From: Guenter Roeck <linux@roeck-us.net>
To: Crystal Guo <crystal.guo@mediatek.com>
Cc: wim@linux-watchdog.org, robh+dt@kernel.org,
matthias.bgg@gmail.com, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
seiya.wang@mediatek.com
Subject: Re: [v6,4/4] watchdog: mt8192: add wdt support
Date: Sat, 23 Jan 2021 10:27:16 -0800 [thread overview]
Message-ID: <20210123182716.GA59961@roeck-us.net> (raw)
In-Reply-To: <20201014131936.20584-5-crystal.guo@mediatek.com>
On Wed, Oct 14, 2020 at 09:19:36PM +0800, Crystal Guo wrote:
> Add support for watchdog device found in MT8192 SoC
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
FTR, I now added this series to my watchdog-next tree. Hopefully
Wim will pick it up from there.
Ultimately the bindings should be updated to yaml format, but I don't see
the point of holding up the series for that, and the series has been
collecting dust for long enough.
Guenter
> ---
> drivers/watchdog/mtk_wdt.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index d6a6393f609d..aef0c2db6a11 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -11,6 +11,7 @@
>
> #include <dt-bindings/reset-controller/mt2712-resets.h>
> #include <dt-bindings/reset-controller/mt8183-resets.h>
> +#include <dt-bindings/reset-controller/mt8192-resets.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/init.h>
> @@ -76,6 +77,10 @@ static const struct mtk_wdt_data mt8183_data = {
> .toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM,
> };
>
> +static const struct mtk_wdt_data mt8192_data = {
> + .toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,
> +};
> +
> static int toprgu_reset_update(struct reset_controller_dev *rcdev,
> unsigned long id, bool assert)
> {
> @@ -322,6 +327,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
> { .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
> { .compatible = "mediatek,mt6589-wdt" },
> { .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
> + { .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);
prev parent reply other threads:[~2021-01-23 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 13:19 [v6,0/4] watchdog: mt8192: add wdt support Crystal Guo
2020-10-14 13:19 ` [v6,1/4] dt-binding: mediatek: watchdog: fix the description of compatible Crystal Guo
2020-10-14 13:19 ` [v6,2/4] dt-binding: mediatek: mt8192: update mtk-wdt document Crystal Guo
2020-11-16 12:27 ` Crystal Guo
2020-12-21 0:59 ` Nicolas Boichat
2020-12-26 8:55 ` Crystal Guo
2021-01-23 18:21 ` Guenter Roeck
2020-10-14 13:19 ` [v6,3/4] dt-binding: mt8192: add toprgu reset-controller head file Crystal Guo
2020-10-14 13:19 ` [v6,4/4] watchdog: mt8192: add wdt support Crystal Guo
2021-01-23 18:27 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123182716.GA59961@roeck-us.net \
--to=linux@roeck-us.net \
--cc=crystal.guo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).