* [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error
@ 2020-02-03 16:10 Randy Dunlap
2020-02-03 17:49 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-02-03 16:10 UTC (permalink / raw)
To: LKML, linux-watchdog; +Cc: wim, Guenter Roeck, Matthias Brugger
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error when CONFIG_RESET_CONTROLLER is not set by
selecting RESET_CONTROLLER.
ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe':
mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-watchdog@vger.kernel.org
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200203.orig/drivers/watchdog/Kconfig
+++ linux-next-20200203/drivers/watchdog/Kconfig
@@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG
tristate "Mediatek SoCs watchdog support"
depends on ARCH_MEDIATEK || COMPILE_TEST
select WATCHDOG_CORE
+ select RESET_CONTROLLER
help
Say Y here to include support for the watchdog timer
in Mediatek SoCs.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error
2020-02-03 16:10 [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error Randy Dunlap
@ 2020-02-03 17:49 ` Guenter Roeck
2020-02-17 11:55 ` Nicolas Boichat
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2020-02-03 17:49 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, linux-watchdog, wim, Matthias Brugger
On Mon, Feb 03, 2020 at 08:10:29AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_RESET_CONTROLLER is not set by
> selecting RESET_CONTROLLER.
>
> ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe':
> mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-watchdog@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200203.orig/drivers/watchdog/Kconfig
> +++ linux-next-20200203/drivers/watchdog/Kconfig
> @@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG
> tristate "Mediatek SoCs watchdog support"
> depends on ARCH_MEDIATEK || COMPILE_TEST
> select WATCHDOG_CORE
> + select RESET_CONTROLLER
> help
> Say Y here to include support for the watchdog timer
> in Mediatek SoCs.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error
2020-02-03 17:49 ` Guenter Roeck
@ 2020-02-17 11:55 ` Nicolas Boichat
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Boichat @ 2020-02-17 11:55 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Randy Dunlap, LKML, linux-watchdog, wim, Matthias Brugger
On Tue, Feb 4, 2020 at 1:49 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Mon, Feb 03, 2020 at 08:10:29AM -0800, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Fix build error when CONFIG_RESET_CONTROLLER is not set by
> > selecting RESET_CONTROLLER.
> >
> > ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe':
> > mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register'
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Matthias Brugger <matthias.bgg@gmail.com>
> > Cc: linux-watchdog@vger.kernel.org
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Wim: Can you please help pick this patch? This seems necessary.
I'd also add this to the commit message:
Fixes: c254e103082b74e ("watchdog: mtk_wdt: mt8183: Add reset controller")
Thanks!
> > ---
> > drivers/watchdog/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20200203.orig/drivers/watchdog/Kconfig
> > +++ linux-next-20200203/drivers/watchdog/Kconfig
> > @@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG
> > tristate "Mediatek SoCs watchdog support"
> > depends on ARCH_MEDIATEK || COMPILE_TEST
> > select WATCHDOG_CORE
> > + select RESET_CONTROLLER
> > help
> > Say Y here to include support for the watchdog timer
> > in Mediatek SoCs.
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-17 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 16:10 [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error Randy Dunlap
2020-02-03 17:49 ` Guenter Roeck
2020-02-17 11:55 ` Nicolas Boichat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).