From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "hdegoede@redhat.com" <hdegoede@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"sre@kernel.org" <sre@kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"wens@csie.org" <wens@csie.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"agross@kernel.org" <agross@kernel.org>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers
Date: Wed, 21 Apr 2021 12:54:29 +0000 [thread overview]
Message-ID: <d434f4abf974cccfe51132c37c35843b1bbc2b77.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <171af93e-e5be-b35f-23d4-0ccf37062902@redhat.com>
On Wed, 2021-04-21 at 14:26 +0200, Hans de Goede wrote:
> Hi,
>
> On 4/21/21 2:17 PM, Vaittinen, Matti wrote:
> > On Wed, 2021-04-21 at 13:58 +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 4/21/21 9:51 AM, Matti Vaittinen wrote:
> > > > On Tue, 2021-03-23 at 15:19 +0100, Greg KH wrote:
> > > > > On Tue, Mar 23, 2021 at 02:58:28PM +0100, Hans de Goede
> > > > > wrote:
> > > > > > Hi,
> > > > > >
> > > > > > On 3/23/21 2:56 PM, Matti Vaittinen wrote:
> > > > > > > Devm helper header containing small inline helpers was
> > > > > > > added.
> > > > > > > Hans promised to maintain it.
> > > > > > >
> > > > > > > Add Hans as maintainer and myself as designated reviewer.
> > > > > > >
> > > > > > Ultimately this is up to Greg though, so lets wait and see
> > > > > > what
> > > > > > Greg has to say about this.
> > > > >
> > > > > Can we move some of the devm_* calls in include/device.h into
> > > > > here as
> > > > > well so that you all can be in charge of them instead of me?
...
> > but what comes to my (not always so humble) opinion - most of
> > the devm functions in device.h are tightly related to the device
> > interface or devres. Thus the device.h feels like appropriate place
> > for
> > most of those.
>
> I agree with you that most devm_ functions in device.h are probably
> left there. Moving them will also mean modifying all the drivers
> which use them to include the new devm-helpers.h include file
> which seems like needless churn.
>
> > OTOH, the kmalloc/kfree related functions, strdub and
> > kmemdub might be candidates for move - those are not really "device
> > things".
>
> I'm certainly open to moving some functions to devm-helpers.h, but
> also see above about needless churn.
I agree. Whether the move is worth all the hassle depends on how much
Greg _really_ wishes to get rid of those devm functions. Especially the
allocs are used _a lot_.
Best Regards
--Matti
next prev parent reply other threads:[~2021-04-21 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:49 [PATCH v3 0/8] Add managed version of delayed work init Matti Vaittinen
2021-03-23 13:56 ` [PATCH v3 1/8] workqueue: Add resource " Matti Vaittinen
2021-03-23 13:59 ` Hans de Goede
2021-03-23 13:56 ` [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers Matti Vaittinen
2021-03-23 13:58 ` Hans de Goede
2021-03-23 14:19 ` Greg KH
2021-04-21 7:51 ` Matti Vaittinen
2021-04-21 11:58 ` Hans de Goede
2021-04-21 12:09 ` Greg KH
2021-04-21 12:39 ` Matti Vaittinen
2021-04-21 12:17 ` Vaittinen, Matti
2021-04-21 12:26 ` Hans de Goede
2021-04-21 12:54 ` Vaittinen, Matti [this message]
2021-03-23 13:58 ` [PATCH v3 8/8] watchdog: retu_wdt: Clean-up by using managed work init Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d434f4abf974cccfe51132c37c35843b1bbc2b77.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mgross@linux.intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).