From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Mark Gross <mgross@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-hwmon@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers
Date: Wed, 21 Apr 2021 10:51:13 +0300 [thread overview]
Message-ID: <da0233f3223d7c0816581afe0969caf0abe20378.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <YFn5CSB1O3i+SzgR@kroah.com>
On Tue, 2021-03-23 at 15:19 +0100, Greg KH wrote:
> On Tue, Mar 23, 2021 at 02:58:28PM +0100, Hans de Goede wrote:
> > Hi,
> >
> > On 3/23/21 2:56 PM, Matti Vaittinen wrote:
> > > Devm helper header containing small inline helpers was added.
> > > Hans promised to maintain it.
> > >
> > > Add Hans as maintainer and myself as designated reviewer.
> > >
> > Ultimately this is up to Greg though, so lets wait and see what
> > Greg has to say about this.
>
> Can we move some of the devm_* calls in include/device.h into here as
> well so that you all can be in charge of them instead of me?
Seems like this was left w/o answer. I guess the question was pointed
to Hans - but what comes to my (not always so humble) opinion - most of
the devm functions in device.h are tightly related to the device
interface or devres. Thus the device.h feels like appropriate place for
most of those. OTOH, the kmalloc/kfree related functions, strdub and
kmemdub might be candidates for move - those are not really "device
things".
But this is really not my call :)
Best Regards
Matti Vaittinen
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
next prev parent reply other threads:[~2021-04-21 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:49 [PATCH v3 0/8] Add managed version of delayed work init Matti Vaittinen
2021-03-23 13:56 ` [PATCH v3 1/8] workqueue: Add resource " Matti Vaittinen
2021-03-23 13:59 ` Hans de Goede
2021-03-23 13:56 ` [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers Matti Vaittinen
2021-03-23 13:58 ` Hans de Goede
2021-03-23 14:19 ` Greg KH
2021-04-21 7:51 ` Matti Vaittinen [this message]
2021-04-21 11:58 ` Hans de Goede
2021-04-21 12:09 ` Greg KH
2021-04-21 12:39 ` Matti Vaittinen
2021-04-21 12:17 ` Vaittinen, Matti
2021-04-21 12:26 ` Hans de Goede
2021-04-21 12:54 ` Vaittinen, Matti
2021-03-23 13:58 ` [PATCH v3 8/8] watchdog: retu_wdt: Clean-up by using managed work init Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da0233f3223d7c0816581afe0969caf0abe20378.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mgross@linux.intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).