From: Kalle Valo <kvalo@codeaurora.org>
To: Luciano Coelho <luciano.coelho@intel.com>
Cc: Anders Kaseorg <andersk@mit.edu>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v1.2] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"
Date: Tue, 3 Dec 2019 09:08:54 +0000 [thread overview]
Message-ID: <0101016ecb05064e-722ee289-5d94-4275-a1f9-24dd0cfaeef7-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <7808e30fc20684cc0b47a5caf36a747e179c035c.camel@intel.com> (Luciano Coelho's message of "Tue, 03 Dec 2019 09:41:54 +0200")
Luciano Coelho <luciano.coelho@intel.com> writes:
> On Tue, 2019-12-03 at 07:39 +0000, Kalle Valo wrote:
>> Anders Kaseorg <andersk@mit.edu> writes:
>>
>> > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.
>> >
>> > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
>> > attempted to fix the same bug (dead assignments to the local variable
>> > cfg), but they did so in incompatible ways. When they were both merged,
>> > independently of each other, the combination actually caused the bug to
>> > reappear, leading to a firmware crash on boot for some cards.
>> >
>> > https://bugzilla.kernel.org/show_bug.cgi?id=205719
>> >
>> > Signed-off-by: Anders Kaseorg <andersk@mit.edu>
>> > ---
>> > [Nope it was more than just format=flowed damage. This one should be
>> > better for real.]
>>
>> This is nitpicking but as a general comment I would prefer to use simple
>> version numbering v2, v3 and so on. Trying to sort v1.2 in a script is
>> awful. So calling this version v3 is very much preferred, it's not like
>> we are running out of numbers :)
>
> Kalle, this patch makes sense. There was some merge damage because the
> functions were moved around and the local variables' names have
> changed, causing this mess.
>
> Can you please take this patch to v5.4 fixes when you're satisfied?
Ok, I assigned this to myself and queue for v5.5.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-12-03 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 23:28 [PATCH] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection" Anders Kaseorg
2019-12-02 21:56 ` [PATCH v1.1] " Anders Kaseorg
2019-12-02 22:09 ` [PATCH v1.2] " Anders Kaseorg
2019-12-03 7:39 ` Kalle Valo
2019-12-03 7:41 ` Luciano Coelho
2019-12-03 9:08 ` Kalle Valo [this message]
2019-12-03 9:10 ` Luciano Coelho
2019-12-10 8:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101016ecb05064e-722ee289-5d94-4275-a1f9-24dd0cfaeef7-000000@us-west-2.amazonses.com \
--to=kvalo@codeaurora.org \
--cc=andersk@mit.edu \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).