From: Luciano Coelho <luciano.coelho@intel.com>
To: Kalle Valo <kvalo@codeaurora.org>, Anders Kaseorg <andersk@mit.edu>
Cc: Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v1.2] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"
Date: Tue, 03 Dec 2019 09:41:54 +0200 [thread overview]
Message-ID: <7808e30fc20684cc0b47a5caf36a747e179c035c.camel@intel.com> (raw)
In-Reply-To: <0101016ecab326d1-88123857-cf37-47ab-b452-13658625364c-000000@us-west-2.amazonses.com>
On Tue, 2019-12-03 at 07:39 +0000, Kalle Valo wrote:
> Anders Kaseorg <andersk@mit.edu> writes:
>
> > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.
> >
> > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
> > attempted to fix the same bug (dead assignments to the local variable
> > cfg), but they did so in incompatible ways. When they were both merged,
> > independently of each other, the combination actually caused the bug to
> > reappear, leading to a firmware crash on boot for some cards.
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=205719
> >
> > Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> > ---
> > [Nope it was more than just format=flowed damage. This one should be
> > better for real.]
>
> This is nitpicking but as a general comment I would prefer to use simple
> version numbering v2, v3 and so on. Trying to sort v1.2 in a script is
> awful. So calling this version v3 is very much preferred, it's not like
> we are running out of numbers :)
Kalle, this patch makes sense. There was some merge damage because the
functions were moved around and the local variables' names have
changed, causing this mess.
Can you please take this patch to v5.4 fixes when you're satisfied?
Thanks!
Acked-by: Luca Coelho <luciano.coelho@intel.com>
--
Cheers,
Luca.
next prev parent reply other threads:[~2019-12-03 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 23:28 [PATCH] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection" Anders Kaseorg
2019-12-02 21:56 ` [PATCH v1.1] " Anders Kaseorg
2019-12-02 22:09 ` [PATCH v1.2] " Anders Kaseorg
2019-12-03 7:39 ` Kalle Valo
2019-12-03 7:41 ` Luciano Coelho [this message]
2019-12-03 9:08 ` Kalle Valo
2019-12-03 9:10 ` Luciano Coelho
2019-12-10 8:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7808e30fc20684cc0b47a5caf36a747e179c035c.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=andersk@mit.edu \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).