From: Johannes Berg <johannes@sipsolutions.net>
To: Peter Collingbourne <pcc@google.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: avoid holding the RTNL when calling the driver
Date: Thu, 18 Mar 2021 20:13:08 +0100 [thread overview]
Message-ID: <05ede675a6829ab3f3e69a1766a9df39f18ad024.camel@sipsolutions.net> (raw)
In-Reply-To: <CAMn1gO6PoOZyejd_Pu0fj9DHz7d8ty8-sb8voRvXd3=-XV23jA@mail.gmail.com> (sfid-20210318_201103_082515_6B31AB13)
On Thu, 2021-03-18 at 12:10 -0700, Peter Collingbourne wrote:
> Yes, it was deadlocking after a few minutes, although at that time I
> hadn't confirmed that the deadlock was being caused by the patch or by
> some other issue.
Ah ok :)
> > In any case, I fixed it here, I believe:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=77cbf790e5b482256662e14c8b6ef4fecb07d06d
>
> I cherry-picked that patch and tested it on my setup, and it fixed
> both the warnings and the deadlocks. So if you like you can add my:
>
> Tested-by: Peter Collingbourne <pcc@google.com>
Too late since it's already applied and just got into net also (so
hopefully into rc4), but thanks for confirming that it works!
johannes
next prev parent reply other threads:[~2021-03-18 19:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 22:52 [PATCH v2] cfg80211: avoid holding the RTNL when calling the driver Peter Collingbourne
2021-03-18 7:55 ` Johannes Berg
2021-03-18 19:10 ` Peter Collingbourne
2021-03-18 19:13 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-19 9:21 Johannes Berg
2021-01-20 18:03 ` Johannes Berg
2021-01-22 14:42 ` Johannes Berg
[not found] ` <CGME20210122121108eucas1p2d153ab9c3a95015221b470a66a0c8458@eucas1p2.samsung.com>
2021-01-22 12:11 ` Marek Szyprowski
2021-01-22 12:27 ` Johannes Berg
2021-01-25 11:56 ` Marek Szyprowski
2021-01-25 12:34 ` Johannes Berg
2021-01-25 21:36 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05ede675a6829ab3f3e69a1766a9df39f18ad024.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pcc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).