From: Peter Collingbourne <pcc@google.com>
To: johannes.berg@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: avoid holding the RTNL when calling the driver
Date: Wed, 17 Mar 2021 15:52:07 -0700 [thread overview]
Message-ID: <CAMn1gO7evHe+pvcFwv1XE+y090CSWwXL=pRKjZwmnrZa3j4gtg@mail.gmail.com> (raw)
Hi Johannes,
I'm seeing warnings like this on 5.12.0-rc2 which I think were caused
by your patch.
[ 4.898946][ T455] ------------[ cut here ]------------
[ 4.899434][ T455] RTNL: assertion failed at net/core/dev.c (10988)
[ 4.900191][ T455] WARNING: CPU: 1 PID: 455 at
net/core/dev.c:10988 dev_change_net_namespace+0x680/0x730
[ 4.901042][ T455] Modules linked in: zram zsmalloc
vmw_vsock_virtio_transport virtio_pmem virtio_pci
virtio_pci_modern_dev virtio_net virtio_mmio virtio_input
virtio_console virtio_blk virtio_rng virtio_gpu virtio_dma_buf
vexpress_sysreg system_heap snd_hda_intel snd_intel_dspcfg
snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hda_core
rtc_test psmouse net_failover nd_virtio md_mod mac80211_hwsim
ledtrig_audio hci_vhci goldfish_sync(O) goldfish_pipe(O)
goldfish_battery(O) goldfish_address_space(O) failover dummy_hcd
dummy_cpufreq clk_vexpress_osc vexpress_config armmmci ambakmi
[ 4.906291][ T455] CPU: 1 PID: 455 Comm: iw Tainted: G O
5.12.0-rc2-mainline-08319-g19e2e1d25c10 #1
[ 4.907475][ T455] Hardware name: linux,ranchu (DT)
[ 4.907988][ T455] pstate: 60400005 (nZCv daif +PAN -UAO -TCO BTYPE=--)
[ 4.908627][ T455] pc : dev_change_net_namespace+0x680/0x730
[ 4.909168][ T455] lr : dev_change_net_namespace+0x680/0x730
[ 4.909725][ T455] sp : ffffffc012df3830
[ 4.910118][ T455] x29: ffffffc012df3870 x28: ffffff800dd8b240
[ 4.910693][ T455] x27: ffffff801ca76000 x26: 0000000000000008
[ 4.911212][ T455] x25: ffffff801cac3210 x24: ffffffc011b5ac40
[ 4.911848][ T455] x23: ffffff801ca768e0 x22: ffffffc011798506
[ 4.912382][ T455] x21: ffffffc011b5ac40 x20: ffffff800db0b240
[ 4.912793][ T455] x19: ffffff801cb00000 x18: ffffffc012549080
[ 4.913200][ T455] x17: 0000000000000006 x16: 000000000000b70d
[ 4.913612][ T455] x15: 0000000000000019 x14: 02a5000000000000
[ 4.914135][ T455] x13: 0000000000000000 x12: 000000005c961000
[ 4.914752][ T455] x11: ffffffc0119d6070 x10: 0000000000000000
[ 4.915238][ T455] x9 : a0858573fdaceb00 x8 : a0858573fdaceb00
[ 4.915836][ T455] x7 : ffffffc011715fa9 x6 : 0000000000000003
[ 4.916352][ T455] x5 : 0000000000000001 x4 : 0000000000000001
[ 4.916909][ T455] x3 : ffffff800dd8b240 x2 : ffffff807fbb5988
[ 4.917411][ T455] x1 : 0000000000000000 x0 : 0000000000000030
[ 4.918034][ T455] Call trace:
[ 4.918327][ T455] dev_change_net_namespace+0x680/0x730
[ 4.918827][ T455] cfg80211_switch_netns+0x90/0x1b8
[ 4.919305][ T455] nl80211_wiphy_netns+0x6c/0xf0
[ 4.919772][ T455] genl_rcv_msg+0x3c0/0x3ec
[ 4.920163][ T455] netlink_rcv_skb+0x108/0x124
[ 4.920650][ T455] genl_rcv+0x38/0x54
[ 4.920955][ T455] netlink_unicast_kernel+0xa0/0x140
[ 4.921484][ T455] netlink_unicast+0xfc/0x1a4
[ 4.921918][ T455] netlink_sendmsg+0x28c/0x320
[ 4.922363][ T455] ____sys_sendmsg+0x17c/0x234
[ 4.922786][ T455] __sys_sendmsg+0x190/0x1e8
[ 4.923183][ T455] __arm64_sys_sendmsg+0x28/0x38
[ 4.923557][ T455] el0_svc_common+0x94/0x118
[ 4.923921][ T455] do_el0_svc+0x28/0x88
[ 4.924223][ T455] el0_svc+0x2c/0x90
[ 4.924582][ T455] el0_sync_handler+0x88/0xec
[ 4.925113][ T455] el0_sync+0x194/0x1c0
[ 4.925572][ T455] ---[ end trace 8f99239e8a4e6dad ]---
[ 4.926322][ T455] ------------[ cut here ]------------
Peter
next reply other threads:[~2021-03-17 22:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 22:52 Peter Collingbourne [this message]
2021-03-18 7:55 ` [PATCH v2] cfg80211: avoid holding the RTNL when calling the driver Johannes Berg
2021-03-18 19:10 ` Peter Collingbourne
2021-03-18 19:13 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2021-01-19 9:21 Johannes Berg
2021-01-20 18:03 ` Johannes Berg
2021-01-22 14:42 ` Johannes Berg
[not found] ` <CGME20210122121108eucas1p2d153ab9c3a95015221b470a66a0c8458@eucas1p2.samsung.com>
2021-01-22 12:11 ` Marek Szyprowski
2021-01-22 12:27 ` Johannes Berg
2021-01-25 11:56 ` Marek Szyprowski
2021-01-25 12:34 ` Johannes Berg
2021-01-25 21:36 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMn1gO7evHe+pvcFwv1XE+y090CSWwXL=pRKjZwmnrZa3j4gtg@mail.gmail.com' \
--to=pcc@google.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).