From: Johannes Berg <johannes@sipsolutions.net>
To: Karthikeyan Periyasamy <periyasa@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: reject zero MAC address in add station
Date: Fri, 26 Jul 2019 13:06:42 +0200 [thread overview]
Message-ID: <0cc7d0c578b60730e77ecd03e2df240dd1b393a0.camel@sipsolutions.net> (raw)
In-Reply-To: <1563959770-21570-1-git-send-email-periyasa@codeaurora.org>
On Wed, 2019-07-24 at 14:46 +0530, Karthikeyan Periyasamy wrote:
> Don't allow using a zero MAC address as the station
> MAC address. so validated the MAC address using
> is_valid_ether_addr.
Theoretically, all zeroes might have been a valid address at some point.
I see no reason not to reject it, but I'd like to know why you ended up
with this now??
johannes
next prev parent reply other threads:[~2019-07-26 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 9:16 [PATCH] mac80211: reject zero MAC address in add station Karthikeyan Periyasamy
2019-07-26 11:06 ` Johannes Berg [this message]
2019-07-26 14:06 ` Karthikeyan Periyasamy
2019-07-26 14:07 ` Johannes Berg
2019-07-26 14:23 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc7d0c578b60730e77ecd03e2df240dd1b393a0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=periyasa@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).