From: Karthikeyan Periyasamy <periyasa@codeaurora.org>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
Karthikeyan Periyasamy <periyasa@codeaurora.org>
Subject: [PATCH] mac80211: reject zero MAC address in add station
Date: Wed, 24 Jul 2019 14:46:10 +0530 [thread overview]
Message-ID: <1563959770-21570-1-git-send-email-periyasa@codeaurora.org> (raw)
Don't allow using a zero MAC address as the station
MAC address. so validated the MAC address using
is_valid_ether_addr.
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
net/mac80211/cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index 4f12d04..cf97b07 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -1539,7 +1539,7 @@ static int ieee80211_add_station(struct wiphy *wiphy, struct net_device *dev,
if (ether_addr_equal(mac, sdata->vif.addr))
return -EINVAL;
- if (is_multicast_ether_addr(mac))
+ if (!is_valid_ether_addr(mac))
return -EINVAL;
sta = sta_info_alloc(sdata, mac, GFP_KERNEL);
--
1.9.1
next reply other threads:[~2019-07-24 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 9:16 Karthikeyan Periyasamy [this message]
2019-07-26 11:06 ` [PATCH] mac80211: reject zero MAC address in add station Johannes Berg
2019-07-26 14:06 ` Karthikeyan Periyasamy
2019-07-26 14:07 ` Johannes Berg
2019-07-26 14:23 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563959770-21570-1-git-send-email-periyasa@codeaurora.org \
--to=periyasa@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).