* [PATCH v3] iw: Add support for controlling tx power for per station
@ 2019-02-22 6:37 Balaji Pothunoori
0 siblings, 0 replies; 3+ messages in thread
From: Balaji Pothunoori @ 2019-02-22 6:37 UTC (permalink / raw)
To: johannes, linux-wireless; +Cc: ath10k, Ashok Raj Nagarajan, Balaji Pothunoori
From: Ashok Raj Nagarajan <arnagara@codeaurora.org>
This patch allows userspace to set transmit power,
in dBm units, to a station associated to the AP.
To set a limit tx power of 20 dBm:
iw wlan0 station set <mac-addr> txpwr limit 20
To revert the user defined tx power for a station:
iw wlan0 station set <mac-addr> txpwr auto
Co-developed-by: Balaji Pothunoori <bpothuno@codeaurora.org>
Signed-off-by: Ashok Raj Nagarajan <arnagara@codeaurora.org>
Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org>
---
v2: modified user configured units to dBm from mBm
v3: no changes, rebased
station.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 71 insertions(+)
diff --git a/station.c b/station.c
index e1477ef..8e0e852 100644
--- a/station.c
+++ b/station.c
@@ -651,6 +651,7 @@ COMMAND(station, del, "<MAC address> [subtype <subtype>] [reason-code <code>]",
static const struct cmd *station_set_plink;
static const struct cmd *station_set_vlan;
static const struct cmd *station_set_mesh_power_mode;
+static const struct cmd *station_set_txpwr;
static const struct cmd *select_station_cmd(int argc, char **argv)
{
@@ -662,6 +663,8 @@ static const struct cmd *select_station_cmd(int argc, char **argv)
return station_set_vlan;
if (strcmp(argv[1], "mesh_power_mode") == 0)
return station_set_mesh_power_mode;
+ if (strcmp(argv[1], "txpwr") == 0)
+ return station_set_txpwr;
return NULL;
}
@@ -813,6 +816,74 @@ COMMAND_ALIAS(station, set, "<MAC address> mesh_power_mode "
"Set link-specific mesh power mode for this station",
select_station_cmd, station_set_mesh_power_mode);
+static int handle_station_set_txpwr(struct nl80211_state *state,
+ struct nl_msg *msg,
+ int argc, char **argv,
+ enum id_input id)
+{
+ enum nl80211_tx_power_setting type;
+ unsigned char mac_addr[ETH_ALEN];
+ int sta_txpwr = 0;
+ char *err = NULL;
+
+ if (argc != 3 && argc != 4)
+ return 1;
+
+ if (mac_addr_a2n(mac_addr, argv[0])) {
+ fprintf(stderr, "invalid mac address\n");
+ return 2;
+ }
+
+ NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, mac_addr);
+ argc--;
+ argv++;
+
+ if (strcmp("txpwr", argv[0]) != 0)
+ return 1;
+ argc--;
+ argv++;
+
+ if (!strcmp(argv[0], "auto"))
+ type = NL80211_TX_POWER_AUTOMATIC;
+ else if (!strcmp(argv[0], "limit"))
+ type = NL80211_TX_POWER_LIMITED;
+ else {
+ printf("Invalid parameter: %s\n", argv[0]);
+ return 2;
+ }
+
+ NLA_PUT_U8(msg, NL80211_ATTR_STA_TX_POWER_SETTING, type);
+
+ if (type != NL80211_TX_POWER_AUTOMATIC) {
+ if (argc != 2) {
+ printf("Missing TX power level argument.\n");
+ return 2;
+ }
+
+ argc--;
+ argv++;
+
+ sta_txpwr = strtoul(argv[0], &err, 0);
+
+ if (sta_txpwr)
+ NLA_PUT_U16(msg, NL80211_ATTR_STA_TX_POWER, sta_txpwr);
+ }
+
+ argc--;
+ argv++;
+
+ if (argc)
+ return 1;
+
+ return 0;
+ nla_put_failure:
+ return -ENOBUFS;
+}
+COMMAND_ALIAS(station, set, "<MAC address> txpwr <auto|limit> [<tx power dBm>]",
+ NL80211_CMD_SET_STATION, 0, CIB_NETDEV, handle_station_set_txpwr,
+ "Set Tx power for this station.",
+ select_station_cmd, station_set_txpwr);
+
static int handle_station_dump(struct nl80211_state *state,
struct nl_msg *msg,
int argc, char **argv,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] iw: Add support for controlling tx power for per station
2017-02-08 12:01 Ashok Raj Nagarajan
@ 2017-02-15 8:03 ` Johannes Berg
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2017-02-15 8:03 UTC (permalink / raw)
To: Ashok Raj Nagarajan; +Cc: linux-wireless, ath10k, arnagara
> + sta_txpwr = strtoul(argv[0], &err, 0);
you should error-check this.
> + NLA_PUT_U32(msg, NL80211_ATTR_STA_TX_POWER,
> sta_txpwr);
> + }
> +}
> +COMMAND_ALIAS(station, set, "<MAC address> txpwr <auto|limit> [<tx
> power mBm>]",
>
Seems like that should be
<MAC address> txpwr <auto|limit <tx power dBm>>
or so?
I made that dBm there, doing that and parsing floating point numbers
would be nice I think.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3] iw: Add support for controlling tx power for per station
@ 2017-02-08 12:01 Ashok Raj Nagarajan
2017-02-15 8:03 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Ashok Raj Nagarajan @ 2017-02-08 12:01 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, ath10k, arnagara, Ashok Raj Nagarajan
This patch allows userspace to set transmit power, in mBm units, to a
station associated to the AP.
To set a limit tx power of 2000 mBm:
iw wlan0 station set <mac-addr> txpwr limit 2000
To revert the user defined tx power for a station:
iw wlan0 station set <mac-addr> txpwr auto
Signed-off-by: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>
---
v3:
- rebased
station.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/station.c b/station.c
index f3e3da8..8364593 100644
--- a/station.c
+++ b/station.c
@@ -569,6 +569,7 @@ COMMAND(station, del, "<MAC address> [subtype <subtype>] [reason-code <code>]",
static const struct cmd *station_set_plink;
static const struct cmd *station_set_vlan;
static const struct cmd *station_set_mesh_power_mode;
+static const struct cmd *station_set_txpwr;
static const struct cmd *select_station_cmd(int argc, char **argv)
{
@@ -580,6 +581,8 @@ static const struct cmd *select_station_cmd(int argc, char **argv)
return station_set_vlan;
if (strcmp(argv[1], "mesh_power_mode") == 0)
return station_set_mesh_power_mode;
+ if (strcmp(argv[1], "txpwr") == 0)
+ return station_set_txpwr;
return NULL;
}
@@ -731,6 +734,72 @@ COMMAND_ALIAS(station, set, "<MAC address> mesh_power_mode "
"Set link-specific mesh power mode for this station",
select_station_cmd, station_set_mesh_power_mode);
+static int handle_station_set_txpwr(struct nl80211_state *state,
+ struct nl_msg *msg,
+ int argc, char **argv,
+ enum id_input id)
+{
+ enum nl80211_tx_power_setting type;
+ unsigned char mac_addr[ETH_ALEN];
+ unsigned int sta_txpwr = 0;
+ char *err = NULL;
+
+ if (argc != 3 && argc != 4)
+ return 1;
+
+ if (mac_addr_a2n(mac_addr, argv[0])) {
+ fprintf(stderr, "invalid mac address\n");
+ return 2;
+ }
+
+ NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, mac_addr);
+ argc--;
+ argv++;
+
+ if (strcmp("txpwr", argv[0]) != 0)
+ return 1;
+ argc--;
+ argv++;
+
+ if (!strcmp(argv[0], "auto"))
+ type = NL80211_TX_POWER_AUTOMATIC;
+ else if (!strcmp(argv[0], "limit"))
+ type = NL80211_TX_POWER_LIMITED;
+ else {
+ printf("Invalid parameter: %s\n", argv[0]);
+ return 2;
+ }
+
+ NLA_PUT_U32(msg, NL80211_ATTR_STA_TX_POWER_SETTING, type);
+
+ if (type != NL80211_TX_POWER_AUTOMATIC) {
+ if (argc != 2) {
+ printf("Missing TX power level argument.\n");
+ return 2;
+ }
+
+ argc--;
+ argv++;
+
+ sta_txpwr = strtoul(argv[0], &err, 0);
+ NLA_PUT_U32(msg, NL80211_ATTR_STA_TX_POWER, sta_txpwr);
+ }
+
+ argc--;
+ argv++;
+
+ if (argc)
+ return 1;
+
+ return 0;
+ nla_put_failure:
+ return -ENOBUFS;
+}
+COMMAND_ALIAS(station, set, "<MAC address> txpwr <auto|limit> [<tx power mBm>]",
+ NL80211_CMD_SET_STATION, 0, CIB_NETDEV, handle_station_set_txpwr,
+ "Set Tx power for this station.",
+ select_station_cmd, station_set_txpwr);
+
static int handle_station_dump(struct nl80211_state *state,
struct nl_msg *msg,
int argc, char **argv,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-22 6:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 6:37 [PATCH v3] iw: Add support for controlling tx power for per station Balaji Pothunoori
-- strict thread matches above, loose matches on Subject: below --
2017-02-08 12:01 Ashok Raj Nagarajan
2017-02-15 8:03 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).