[PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address

[PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address

[Mao Wenan]

This patch is to use eth_broadcast_addr() to assign broadcast address
insetad of memset().

Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 net/wireless/pmsr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/pmsr.c b/net/wireless/pmsr.c
index de9286703280..21139b82749f 100644
--- a/net/wireless/pmsr.c
+++ b/net/wireless/pmsr.c
@@ -258,7 +258,7 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info)
 	} else {
 		memcpy(req->mac_addr, nla_data(info->attrs[NL80211_ATTR_MAC]),
 		       ETH_ALEN);
-		memset(req->mac_addr_mask, 0xff, ETH_ALEN);
+		eth_broadcast_addr(req->mac_addr_mask);
 	}
 
 	idx = 0;
-- 
2.20.1

Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address

[maowenan]

Add kalle Valo in mail list.

Hi Kalle Valo,
Do you have any comments about this patch?

On 2019/2/16 17:47, Mao Wenan wrote:
> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memset().
> 
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
>  net/wireless/pmsr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/wireless/pmsr.c b/net/wireless/pmsr.c
> index de9286703280..21139b82749f 100644
> --- a/net/wireless/pmsr.c
> +++ b/net/wireless/pmsr.c
> @@ -258,7 +258,7 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info)
>  	} else {
>  		memcpy(req->mac_addr, nla_data(info->attrs[NL80211_ATTR_MAC]),
>  		       ETH_ALEN);
> -		memset(req->mac_addr_mask, 0xff, ETH_ALEN);
> +		eth_broadcast_addr(req->mac_addr_mask);
>  	}
>  
>  	idx = 0;
> 

Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address

[Kalle Valo]

maowenan <maowenan@huawei.com> writes:

> Add kalle Valo in mail list.
>
> Hi Kalle Valo,
> Do you have any comments about this patch?

Why do you ask me? Johannes maintains cfg80211, not me, and he will
provide comments once he reviews the patch (which might take some time,
we do have other tasks as well).

-- 
Kalle Valo

Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address

[maowenan]

On 2019/2/18 21:48, Kalle Valo wrote:
> maowenan <maowenan@huawei.com> writes:
> 
>> Add kalle Valo in mail list.
>>
>> Hi Kalle Valo,
>> Do you have any comments about this patch?
> 
> Why do you ask me? Johannes maintains cfg80211, not me, and he will
> provide comments once he reviews the patch (which might take some time,
> we do have other tasks as well).

I'm sorry for this, my mistake to add wrong maintainer.

> 

Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address

[Dan Carpenter]

On Mon, Feb 18, 2019 at 09:25:06PM +0800, maowenan wrote:
> Add kalle Valo in mail list.
> 
> Hi Kalle Valo,
> Do you have any comments about this patch?
> 

It's not done against a recent net-next so it doesn't apply.

Please give people a few days to reply for networking changes.

regards,
dan caprenter