* Re: [PATCH] zd1211rw: remove false assertion from zd_mac_clear()
[not found] <20190808093203.23752-1-oneukum@suse.com>
@ 2019-08-08 18:05 ` David Miller
0 siblings, 0 replies; only message in thread
From: David Miller @ 2019-08-08 18:05 UTC (permalink / raw)
To: oneukum; +Cc: netdev, dsd, kune, linux-wireless, kvalo
From: Oliver Neukum <oneukum@suse.com>
Date: Thu, 8 Aug 2019 11:32:03 +0200
> The function is called before the lock which is asserted was ever used.
> Just remove it.
>
> Reported-by: syzbot+74c65761783d66a9c97c@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
Please CC: the appropriate driver maitainers and mailing list as this
is clearly specified in the MAINTAINERS file.
Thank you.
> ---
> drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> index da7e63fca9f5..a9999d10ae81 100644
> --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> @@ -223,7 +223,6 @@ void zd_mac_clear(struct zd_mac *mac)
> {
> flush_workqueue(zd_workqueue);
> zd_chip_clear(&mac->chip);
> - lockdep_assert_held(&mac->lock);
> ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
> }
>
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-08 18:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190808093203.23752-1-oneukum@suse.com>
2019-08-08 18:05 ` [PATCH] zd1211rw: remove false assertion from zd_mac_clear() David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).