* [PATCH] ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req()
@ 2019-12-13 10:47 Dan Carpenter
2019-12-18 17:54 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-12-13 10:47 UTC (permalink / raw)
To: Kalle Valo
Cc: Anilkumar Kolli, Rajkumar Manoharan, Miles Hu, ath11k,
linux-wireless, kernel-janitors
The callers unlock this lock so this error path has a double unlock.
Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/ath/ath11k/debug_htt_stats.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c
index 27b301bc1a1b..4b1b1ecd5eae 100644
--- a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c
+++ b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c
@@ -4287,7 +4287,6 @@ int ath11k_dbg_htt_stats_req(struct ath11k *ar)
ret = ath11k_dp_tx_htt_h2t_ext_stats_req(ar, type, &cfg_params, cookie);
if (ret) {
ath11k_warn(ar->ab, "failed to send htt stats request: %d\n", ret);
- mutex_unlock(&ar->conf_mutex);
return ret;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req()
2019-12-13 10:47 [PATCH] ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req() Dan Carpenter
@ 2019-12-18 17:54 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-12-18 17:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Anilkumar Kolli, Rajkumar Manoharan, Miles Hu, ath11k,
linux-wireless, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The callers unlock this lock so this error path has a double unlock.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
cd21c827a155 ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req()
--
https://patchwork.kernel.org/patch/11290409/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-18 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 10:47 [PATCH] ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req() Dan Carpenter
2019-12-18 17:54 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).