* [PATCH] rtw88: Use kfree_skb() instead of kfree()
@ 2020-01-29 17:39 Dan Carpenter
2020-02-12 16:20 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-01-29 17:39 UTC (permalink / raw)
To: Yan-Hsuan Chuang, Chin-Yen Lee
Cc: Kalle Valo, linux-wireless, kernel-janitors
sk_buff structs need to be freed with kfree_skb(), not kfree().
Fixes: b6c12908a33e ("rtw88: Add wowlan net-detect support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 243441453ead..5bdfc70c4529 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -745,7 +745,7 @@ static struct sk_buff *rtw_nlo_info_get(struct ieee80211_hw *hw)
loc = rtw_get_rsvd_page_probe_req_location(rtwdev, ssid);
if (!loc) {
rtw_err(rtwdev, "failed to get probe req rsvd loc\n");
- kfree(skb);
+ kfree_skb(skb);
return NULL;
}
nlo_hdr->location[i] = loc;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtw88: Use kfree_skb() instead of kfree()
2020-01-29 17:39 [PATCH] rtw88: Use kfree_skb() instead of kfree() Dan Carpenter
@ 2020-02-12 16:20 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-02-12 16:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Yan-Hsuan Chuang, Chin-Yen Lee, linux-wireless, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> sk_buff structs need to be freed with kfree_skb(), not kfree().
>
> Fixes: b6c12908a33e ("rtw88: Add wowlan net-detect support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
bafbc6f0b51b rtw88: Use kfree_skb() instead of kfree()
--
https://patchwork.kernel.org/patch/11356627/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-12 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 17:39 [PATCH] rtw88: Use kfree_skb() instead of kfree() Dan Carpenter
2020-02-12 16:20 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).