From: Johannes Berg <johannes@sipsolutions.net>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv6 1/9] nl80211: New netlink command for TID specific configuration
Date: Wed, 21 Aug 2019 09:42:05 +0200 [thread overview]
Message-ID: <82bff92e6fa9ccc968566d30195cd3cd29e17a1d.camel@sipsolutions.net> (raw)
In-Reply-To: <be096df17632b1a71441a23a373682bf@codeaurora.org>
On Sat, 2019-08-10 at 18:10 +0530, Tamizh chelvam wrote:
> On 2019-07-31 14:55, Johannes Berg wrote:
> > On Tue, 2019-06-18 at 10:57 +0530, Tamizh chelvam wrote:
> > > /**
> > > + * enum nl80211_tid_config - TID config state
> > > + * @NL80211_TID_CONFIG_DEFAULT: Default config for the TID
> > > + * @NL80211_TID_CONFIG_ENABLE: Enable config for the TID
> > > + * NL80211_TID_CONFIG_DISABLE: Disable config for the TID
> > > + */
> > > +enum nl80211_tid_config {
> > > + NL80211_TID_CONFIG_DEFAULT,
> > > + NL80211_TID_CONFIG_ENABLE,
> > > + NL80211_TID_CONFIG_DISABLE,
> > > +};
> >
> > Hmm. Looking at this in more detail in patch 3, I don't understand.
> >
> > How is DEFAULT different from "attribute not present", i.e. "no
> > changes"?
> >
> This DEFAULT is used to notify the driver to use default configuration
> value of driver/vif.
> This will be used when the attribute is not present.
Hm, but then why is it valid in the nl80211 attribute? That seems
confusing. Maybe there should rather be a validity bit somewhere in the
internal API, so the nl82011 API doesn't need to be concerned with this?
johannes
next prev parent reply other threads:[~2019-08-21 7:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 5:27 [PATCHv6 0/9] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 1/9] nl80211: New netlink command " Tamizh chelvam
2019-07-11 12:51 ` Sergey Matyukevich
2019-07-31 10:04 ` Tamizh chelvam
2019-07-11 13:13 ` Sergey Matyukevich
2019-07-31 9:19 ` Johannes Berg
2019-07-31 10:28 ` Tamizh chelvam
2019-07-31 9:25 ` Johannes Berg
2019-08-10 12:40 ` Tamizh chelvam
2019-08-21 7:42 ` Johannes Berg [this message]
2019-06-18 5:27 ` [PATCHv6 2/9] nl80211: Add new netlink attribute for TID speicific retry count Tamizh chelvam
2019-07-31 9:24 ` Johannes Berg
2019-08-10 12:06 ` Tamizh chelvam
2019-08-21 7:41 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2019-07-31 9:28 ` Johannes Berg
2019-08-10 12:41 ` Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Tamizh chelvam
2019-07-11 12:54 ` Sergey Matyukevich
2019-07-31 10:08 ` Tamizh chelvam
2019-07-31 9:32 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 6/9] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2019-07-31 9:34 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 7/9] ath10k: Add wmi command support for station specific TID config Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 8/9] ath10k: Add new api to support TID specific configuration Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 9/9] ath10k: Add extended TID configuration support Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82bff92e6fa9ccc968566d30195cd3cd29e17a1d.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).