From: Johannes Berg <johannes@sipsolutions.net>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv6 2/9] nl80211: Add new netlink attribute for TID speicific retry count
Date: Wed, 21 Aug 2019 09:41:10 +0200 [thread overview]
Message-ID: <d37c085c66fd4703f324c5576000a16fe469d3b1.camel@sipsolutions.net> (raw)
In-Reply-To: <66f9219ed5bd03f96f23947c2bb6f990@codeaurora.org>
On Sat, 2019-08-10 at 17:36 +0530, Tamizh chelvam wrote:
>
> > > + [NL80211_TID_ATTR_CONFIG_RETRY] = { .type = NLA_FLAG },
> > > + [NL80211_TID_ATTR_CONFIG_RETRY_SHORT] = NLA_POLICY_MIN(NLA_U8, 0),
> > > + [NL80211_TID_ATTR_CONFIG_RETRY_LONG] = NLA_POLICY_MIN(NLA_U8, 0),
> >
> > min of 0 doesn't make sense, maybe you meant 1? otherwise just don't
> > set
> > anything here.
> >
> The min value changed to 0 from 1 as per the previous discussions, since
> this is a retry count and not a tx count.
> Or Shall I remove this min value to avoid the confusion ?
Yeah, I think then you should just remove the min value. Perhaps a max
value is needed, but I don't know.
> > > + tid_conf->retry_short = -1;
> > > +
> >
> > I guess you should document that -1 means no changes? Not sure how the
> > IEEE80211_TID_CONF_RETRY comes in, you're always setting it, so that's
> > useless - better remove that and document that -1 means no changes?
> >
> The value -1 is to notify the driver to use default value by removing
> peer specific retry count.
Oh. So I think that's slightly different, please document that.
johannes
next prev parent reply other threads:[~2019-08-21 7:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 5:27 [PATCHv6 0/9] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 1/9] nl80211: New netlink command " Tamizh chelvam
2019-07-11 12:51 ` Sergey Matyukevich
2019-07-31 10:04 ` Tamizh chelvam
2019-07-11 13:13 ` Sergey Matyukevich
2019-07-31 9:19 ` Johannes Berg
2019-07-31 10:28 ` Tamizh chelvam
2019-07-31 9:25 ` Johannes Berg
2019-08-10 12:40 ` Tamizh chelvam
2019-08-21 7:42 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 2/9] nl80211: Add new netlink attribute for TID speicific retry count Tamizh chelvam
2019-07-31 9:24 ` Johannes Berg
2019-08-10 12:06 ` Tamizh chelvam
2019-08-21 7:41 ` Johannes Berg [this message]
2019-06-18 5:27 ` [PATCHv6 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2019-07-31 9:28 ` Johannes Berg
2019-08-10 12:41 ` Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Tamizh chelvam
2019-07-11 12:54 ` Sergey Matyukevich
2019-07-31 10:08 ` Tamizh chelvam
2019-07-31 9:32 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 6/9] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2019-07-31 9:34 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 7/9] ath10k: Add wmi command support for station specific TID config Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 8/9] ath10k: Add new api to support TID specific configuration Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 9/9] ath10k: Add extended TID configuration support Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d37c085c66fd4703f324c5576000a16fe469d3b1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).