[PATCH] ca8210: Fix crash by zero initializing data

[PATCH] ca8210: Fix crash by zero initializing data

[Hauke Mehrtens]

The struct cas_control embeds multiple generic SPI structures and we
have to make sure these structures are initialized to default values.
This driver does not set all attributes. When using kmalloc before some
attributes were not initialized and contained random data which caused
random crashes at bootup.

Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/net/ieee802154/ca8210.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 450b16ad40a4..e1a569b99e4a 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -885,7 +885,7 @@ static int ca8210_spi_transfer(
 
 	dev_dbg(&spi->dev, "%s called\n", __func__);
 
-	cas_ctl = kmalloc(sizeof(*cas_ctl), GFP_ATOMIC);
+	cas_ctl = kzalloc(sizeof(*cas_ctl), GFP_ATOMIC);
 	if (!cas_ctl)
 		return -ENOMEM;
 
-- 
2.35.1

Re: [PATCH] ca8210: Fix crash by zero initializing data

[Stefan Schmidt]

Hello.

On 21.11.22 01:22, Hauke Mehrtens wrote:
> The struct cas_control embeds multiple generic SPI structures and we
> have to make sure these structures are initialized to default values.
> This driver does not set all attributes. When using kmalloc before some
> attributes were not initialized and contained random data which caused
> random crashes at bootup.
> 
> Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>   drivers/net/ieee802154/ca8210.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index 450b16ad40a4..e1a569b99e4a 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -885,7 +885,7 @@ static int ca8210_spi_transfer(
>   
>   	dev_dbg(&spi->dev, "%s called\n", __func__);
>   
> -	cas_ctl = kmalloc(sizeof(*cas_ctl), GFP_ATOMIC);
> +	cas_ctl = kzalloc(sizeof(*cas_ctl), GFP_ATOMIC);
>   	if (!cas_ctl)
>   		return -ENOMEM;
>   

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt